Telemetry: Record the number of times we don't fill credentials because of a formSubmitURL mismatch

RESOLVED FIXED in Firefox 37

Status

()

Toolkit
Password Manager
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ckarlof, Assigned: MattN)

Tracking

(Blocks: 1 bug)

unspecified
mozilla38
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox37 fixed, firefox38 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Reporter)

Updated

3 years ago
Priority: -- → P1

Updated

3 years ago
Blocks: 1121119

Updated

3 years ago
Status: NEW → ASSIGNED
Points: --- → 3
Flags: qe-verify?
Flags: firefox-backlog+

Updated

3 years ago
Iteration: --- → 38.3 - 23 Feb
Created attachment 8562541 [details]
MozReview Request: bz://1124888/MattN

/r/3729 - Bug 1124888 - Record the effect of the saved formSubmitURL on autofilling login forms. r=dolske

Pull down this commit:

hg pull review -r 7e58a839a3cf1388164e06388d37616b72946cff
Attachment #8562541 - Flags: review?(dolske)
Flags: qe-verify? → qe-verify-
https://reviewboard.mozilla.org/r/3729/#review3283

Ship It!

::: toolkit/components/passwordmgr/LoginManagerParent.jsm
(Diff revision 1)
> +    if (logins.length === 0) {

Is there a reason for the strict-equality check? Or is it just a typo?

::: toolkit/components/telemetry/Histograms.json
(Diff revision 1)
> +    "description": "The effect of the form action on signon autofill. (0=No effect, 1=Less logins after considering the form action, 2=No logins match form origin and action."

s/Less/Fewer/, I think? I can never remember. :)
Attachment #8562541 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/a0b805de0c8e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8562541 [details]
MozReview Request: bz://1124888/MattN

Approval Request Comment
[Feature/regressing bug #]: Data to help with bug 1121119
[User impact if declined]: Less ideal prioritization of improvements to password manager
[Describe test coverage new/current, TreeHerder]: No tests specifically for telemetry but existing tests for form autofill would catch if this broke something.
[Risks and why]: Low risk, minor change for instrumentation.
[String/UUID change made/needed]: None
Attachment #8562541 - Flags: approval-mozilla-aurora?
Comment on attachment 8562541 [details]
MozReview Request: bz://1124888/MattN

This landed to central when it was still 38 - so I think we're OK here, is that not correct Matt?
Flags: needinfo?(MattN+bmo)
Attachment #8562541 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Comment on attachment 8562541 [details]
MozReview Request: bz://1124888/MattN

(In reply to Lukas Blakk [:lsblakk] use ?needinfo from comment #7)
> This landed to central when it was still 38 - so I think we're OK here, is
> that not correct Matt?

Oh, sorry, I meant to request beta since that's where the other password manager probes landed. It's not super important but nice to have them together and being able to make better decisions on bug 1121119 sooner.
Flags: needinfo?(MattN+bmo)
Attachment #8562541 - Flags: approval-mozilla-beta?
status-firefox37: --- → affected
Comment on attachment 8562541 [details]
MozReview Request: bz://1124888/MattN

It's early enough in Beta to take a password manager Telemetry probe. Beta+
Attachment #8562541 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 8562541 [details]
MozReview Request: bz://1124888/MattN
Attachment #8562541 - Attachment is obsolete: true
Attachment #8619213 - Flags: review+
Created attachment 8619213 [details]
MozReview Request: Bug 1124888 - Record the effect of the saved formSubmitURL on autofilling login forms. r=dolske
You need to log in before you can comment on or make changes to this bug.