1124888 - Telemetry: Record the number of times we don't fill credentials because of a formSubmitURL mismatch

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P1)

Comment 1

[Matthew N. [:MattN]]

Attachment: MozReview Request: bz://1124888/MattN

/r/3729 - Bug 1124888 - Record the effect of the saved formSubmitURL on autofilling login forms. r=dolske

Pull down this commit:

hg pull review -r 7e58a839a3cf1388164e06388d37616b72946cff

Comment 2

[Justin Dolske [:Dolske]]

https://reviewboard.mozilla.org/r/3729/#review3283

Ship It!

::: toolkit/components/passwordmgr/LoginManagerParent.jsm
(Diff revision 1)
> +    if (logins.length === 0) {

Is there a reason for the strict-equality check? Or is it just a typo?

::: toolkit/components/telemetry/Histograms.json
(Diff revision 1)
> +    "description": "The effect of the form action on signon autofill. (0=No effect, 1=Less logins after considering the form action, 2=No logins match form origin and action."

s/Less/Fewer/, I think? I can never remember. :)

Comment 3

[Matthew N. [:MattN]]

Comments addressed. Checkin-needed for https://reviewboard-hg.mozilla.org/gecko/rev/5717235d7cb426a9342b2d399e00e1920d04cd06

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0b805de0c8e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0b805de0c8e

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8562541 [details]
MozReview Request: bz://1124888/MattN

Approval Request Comment
[Feature/regressing bug #]: Data to help with bug 1121119
[User impact if declined]: Less ideal prioritization of improvements to password manager
[Describe test coverage new/current, TreeHerder]: No tests specifically for telemetry but existing tests for form autofill would catch if this broke something.
[Risks and why]: Low risk, minor change for instrumentation.
[String/UUID change made/needed]: None

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8562541 [details]
MozReview Request: bz://1124888/MattN

This landed to central when it was still 38 - so I think we're OK here, is that not correct Matt?

Comment 8

[Matthew N. [:MattN]]

Comment on attachment 8562541 [details]
MozReview Request: bz://1124888/MattN

(In reply to Lukas Blakk [:lsblakk] use ?needinfo from comment #7)
> This landed to central when it was still 38 - so I think we're OK here, is
> that not correct Matt?

Oh, sorry, I meant to request beta since that's where the other password manager probes landed. It's not super important but nice to have them together and being able to make better decisions on bug 1121119 sooner.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8562541 [details]
MozReview Request: bz://1124888/MattN

It's early enough in Beta to take a password manager Telemetry probe. Beta+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/191548235ce3

Comment 12

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1124888 - Record the effect of the saved formSubmitURL on autofilling login forms. r=dolske