1124890 - Replace LookProperty with GetOwnProperty in ObjectToSource

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[Tom S [:evilpie]]

Attachment: v1 object-tosource

ObjectToSource only seems to only enumerate own properties.

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 8553361 [details] [diff] [review]
v1 object-tosource

Review of attachment 8553361 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/builtin/Object.cpp
@@ -255,5 @@
> -             * undefined.
> -             */
> -            if (gsop[j] && val[j].isUndefined())
> -                continue;
> -

As I recall, this old code took effect for situations like this:

  var desc = { get: undefined, set: undefined, configurable: true, enumerable: true };
  var obj = Object.defineProperty({}, "prop", desc);
  obj.toSource();

Please add a stupid test somewhere (in an extensions/ folder if a jstest) that does this, to be sure this works.

Comment 2

[Tom S [:evilpie]]

Attachment: object-tosource

Good catch!

Comment 3

[Tom S [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/42d4b2cb18b6

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/42d4b2cb18b6