1124920 - Remove PLDHashTable::Operate()

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nicholas Nethercote [inactive]]

PLDHashTableOperate() just complicates things. Let's remove it. It'll allow us to stop overloading PLDHashOperator for two different things.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1a) - Remove PLDHashTable::Operate()

This is most of the change. But I left the bodies of Lookup/Add/Remove at the
same indentation level because this makes the diff much easier to read. I'll
post a follow-up patch that changes just the indentation level of that code,
and then fold them together before landing.

(I just now realized I probably could have done a |diff -w| instead, but I've
already made the split this way so I'll just roll with it.)

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 1b) - Remove PLDHashTable::Operate()

This is just indentation changes.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8553388 [details] [diff] [review]
(part 1a) - Remove PLDHashTable::Operate()

Review of attachment 8553388 [details] [diff] [review]:
-----------------------------------------------------------------

Should I set f+ for "forgiveness granted" too? :)

Comment 4

[Nicholas Nethercote [inactive]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e911d420faf

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e060a6c859e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9e060a6c859e