Closed Bug 1124920 Opened 5 years ago Closed 5 years ago

Remove PLDHashTable::Operate()

Categories

(Core :: XPCOM, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: njn, Assigned: njn)

References

Details

Attachments

(2 files)

PLDHashTableOperate() just complicates things. Let's remove it. It'll allow us to stop overloading PLDHashOperator for two different things.
This is most of the change. But I left the bodies of Lookup/Add/Remove at the
same indentation level because this makes the diff much easier to read. I'll
post a follow-up patch that changes just the indentation level of that code,
and then fold them together before landing.

(I just now realized I probably could have done a |diff -w| instead, but I've
already made the split this way so I'll just roll with it.)
Attachment #8553388 - Flags: review?(nfroyd)
This is just indentation changes.
Attachment #8553389 - Flags: review?(nfroyd)
Comment on attachment 8553388 [details] [diff] [review]
(part 1a) - Remove PLDHashTable::Operate()

Review of attachment 8553388 [details] [diff] [review]:
-----------------------------------------------------------------

Should I set f+ for "forgiveness granted" too? :)
Attachment #8553388 - Flags: review?(nfroyd) → review+
Attachment #8553389 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/9e060a6c859e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.