Closed
Bug 1124920
Opened 9 years ago
Closed 9 years ago
Remove PLDHashTable::Operate()
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(2 files)
14.46 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
6.57 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
PLDHashTableOperate() just complicates things. Let's remove it. It'll allow us to stop overloading PLDHashOperator for two different things.
Assignee | ||
Comment 1•9 years ago
|
||
This is most of the change. But I left the bodies of Lookup/Add/Remove at the same indentation level because this makes the diff much easier to read. I'll post a follow-up patch that changes just the indentation level of that code, and then fold them together before landing. (I just now realized I probably could have done a |diff -w| instead, but I've already made the split this way so I'll just roll with it.)
Attachment #8553388 -
Flags: review?(nfroyd)
Assignee | ||
Comment 2•9 years ago
|
||
This is just indentation changes.
Attachment #8553389 -
Flags: review?(nfroyd)
Comment 3•9 years ago
|
||
Comment on attachment 8553388 [details] [diff] [review] (part 1a) - Remove PLDHashTable::Operate() Review of attachment 8553388 [details] [diff] [review]: ----------------------------------------------------------------- Should I set f+ for "forgiveness granted" too? :)
Attachment #8553388 -
Flags: review?(nfroyd) → review+
Updated•9 years ago
|
Attachment #8553389 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e911d420faf
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e060a6c859e
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9e060a6c859e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Assignee | ||
Updated•9 years ago
|
Blocks: modernize-pldhash
You need to log in
before you can comment on or make changes to this bug.
Description
•