Closed Bug 1124939 Opened 5 years ago Closed 5 years ago

[EME] Add "individualization-request" to MediaKeyMessageType

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: cpearce, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

https://github.com/w3c/encrypted-media/commit/1a611eab4f93318e4bba4207bbcba673d42cd062
adds "individualization-request" to MediaKeyMessageType.

We'll need to update to include that.
JW: Would you be able to take this?
Flags: needinfo?(jwwang)
sure.
Assignee: nobody → jwwang
Flags: needinfo?(jwwang)
Do I need to change "eme-decrypt-v4" to "eme-decrypt-v5" for just adding a enum field?
Flags: needinfo?(cpearce)
Yes, otherwise when a GMP that uses the new enum tries to use the enum, the IPC serialization could fail in a v4 Gecko without the new enum value.
Flags: needinfo?(cpearce)
Ah, I see. Thanks for the reply.
Add "individualization-request" to MediaKeyMessageType.
Attachment #8555022 - Flags: review?(cpearce)
Comment on attachment 8555022 [details] [diff] [review]
1124939_add_individualization_request-v1.patch

Review of attachment 8555022 [details] [diff] [review]:
-----------------------------------------------------------------

Will need a DOM peer signoff on the WebIDL change here too.
Attachment #8555022 - Flags: review?(cpearce) → review+
Comment on attachment 8555022 [details] [diff] [review]
1124939_add_individualization_request-v1.patch

Hi bz,
Can you reivew the webidl file? Thanks.
Attachment #8555022 - Flags: review+ → review?(bzbarsky)
Comment on attachment 8555022 [details] [diff] [review]
1124939_add_individualization_request-v1.patch

r=me
Attachment #8555022 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ee1ddfd22521
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Attached patch Beta patchSplinter Review
Patch for beta branch as part of EME platform uplift.
Comment on attachment 8572323 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.
Attachment #8572323 - Flags: approval-mozilla-beta?
Comment on attachment 8572323 [details] [diff] [review]
Beta patch

Approved for Beta as part of EME platform uplift.
Attachment #8572323 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.