1124939 - [EME] Add "individualization-request" to MediaKeyMessageType

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://github.com/w3c/encrypted-media/commit/1a611eab4f93318e4bba4207bbcba673d42cd062
adds "individualization-request" to MediaKeyMessageType.

We'll need to update to include that.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

JW: Would you be able to take this?

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

sure.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Do I need to change "eme-decrypt-v4" to "eme-decrypt-v5" for just adding a enum field?

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Yes, otherwise when a GMP that uses the new enum tries to use the enum, the IPC serialization could fail in a v4 Gecko without the new enum value.

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Ah, I see. Thanks for the reply.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1124939_add_individualization_request-v1.patch

Add "individualization-request" to MediaKeyMessageType.

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8555022 [details] [diff] [review]
1124939_add_individualization_request-v1.patch

Review of attachment 8555022 [details] [diff] [review]:
-----------------------------------------------------------------

Will need a DOM peer signoff on the WebIDL change here too.

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8555022 [details] [diff] [review]
1124939_add_individualization_request-v1.patch

Hi bz,
Can you reivew the webidl file? Thanks.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8555022 [details] [diff] [review]
1124939_add_individualization_request-v1.patch

r=me

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=69be7315a89c

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee1ddfd22521

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ee1ddfd22521

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6f83d3fe38da

Comment 14

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Beta patch

Patch for beta branch as part of EME platform uplift.

Comment 15

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8572323 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.

Comment 16

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8572323 [details] [diff] [review]
Beta patch

Approved for Beta as part of EME platform uplift.