[EME] Add "individualization-request" to MediaKeyMessageType

RESOLVED FIXED in Firefox 37

Status

()

Core
Audio/Video
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpearce, Assigned: jwwang)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla38
x86_64
Windows 8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox37 fixed, firefox38 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
https://github.com/w3c/encrypted-media/commit/1a611eab4f93318e4bba4207bbcba673d42cd062
adds "individualization-request" to MediaKeyMessageType.

We'll need to update to include that.
(Reporter)

Comment 1

3 years ago
JW: Would you be able to take this?
Flags: needinfo?(jwwang)
(Assignee)

Comment 2

3 years ago
sure.
Assignee: nobody → jwwang
Flags: needinfo?(jwwang)
(Assignee)

Comment 3

3 years ago
Do I need to change "eme-decrypt-v4" to "eme-decrypt-v5" for just adding a enum field?
Flags: needinfo?(cpearce)
(Reporter)

Comment 4

3 years ago
Yes, otherwise when a GMP that uses the new enum tries to use the enum, the IPC serialization could fail in a v4 Gecko without the new enum value.
Flags: needinfo?(cpearce)
(Assignee)

Comment 5

3 years ago
Ah, I see. Thanks for the reply.
(Assignee)

Comment 6

3 years ago
Created attachment 8555022 [details] [diff] [review]
1124939_add_individualization_request-v1.patch

Add "individualization-request" to MediaKeyMessageType.
Attachment #8555022 - Flags: review?(cpearce)
(Reporter)

Comment 7

3 years ago
Comment on attachment 8555022 [details] [diff] [review]
1124939_add_individualization_request-v1.patch

Review of attachment 8555022 [details] [diff] [review]:
-----------------------------------------------------------------

Will need a DOM peer signoff on the WebIDL change here too.
Attachment #8555022 - Flags: review?(cpearce) → review+
(Assignee)

Comment 8

3 years ago
Comment on attachment 8555022 [details] [diff] [review]
1124939_add_individualization_request-v1.patch

Hi bz,
Can you reivew the webidl file? Thanks.
Attachment #8555022 - Flags: review+ → review?(bzbarsky)
Comment on attachment 8555022 [details] [diff] [review]
1124939_add_individualization_request-v1.patch

r=me
Attachment #8555022 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 10

3 years ago
Try: https://tbpl.mozilla.org/?tree=Try&rev=69be7315a89c
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee1ddfd22521
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ee1ddfd22521
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
(Reporter)

Updated

3 years ago
Blocks: 1137045
(Reporter)

Comment 13

3 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/6f83d3fe38da
status-firefox37: --- → fixed
(Reporter)

Comment 14

3 years ago
Created attachment 8572323 [details] [diff] [review]
Beta patch

Patch for beta branch as part of EME platform uplift.
(Reporter)

Comment 15

3 years ago
Comment on attachment 8572323 [details] [diff] [review]
Beta patch

Requesting retroactive approval for Beta landing as part of EME platform uplift.
Attachment #8572323 - Flags: approval-mozilla-beta?
status-firefox38: --- → fixed
Comment on attachment 8572323 [details] [diff] [review]
Beta patch

Approved for Beta as part of EME platform uplift.
Attachment #8572323 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.