1124992 - [Dialer] not need to listen to telephonyCallGroup.onerror but handle promise

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

After bug 1095362, telephonyCallGroup.add, .remove, .hold and .resume return a Promise. Gaia should turn to use promise resolve/reject to get a request result, instead of relying telephonyCallGroup.onerror.

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Gabriele,
Are you avaialble to work on this bug?  We are willing to have this modification in gaia side.  Then we could work on the furthur bug (bug 1124993) to deprecate telephonyCallGroup.onerror that make our API more clear and concise.

Comment 2

[Gabriele Svelto [:gsvelto]]

Sure, I'm taking it.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] gabrielesvelto:bug-1043165-call-promise-error > mozilla-b2g:master

Comment 4

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8613545 [details] [review]
[gaia] gabrielesvelto:bug-1043165-call-promise-error > mozilla-b2g:master

This is a mostly mechanical change from using onerror to catching the promise's failure with a small twist regarding l10n usage, here's a detailed description of the changes I made:

- CallScreen.showStatusMessage() now uses the argument passing convention described in [1] and internally sets the data-l10n-id getting rid of the deprecated mozL10n.get() use. I did it because we don't want to add new mozL10n.get() calls and the calls handler code would have required them otherwise to show the error message.

- In the calls handler code I've merged the functionality used to merge calls (no pun intended) under the mergeCalls() function. This code is now also responsible for showing the error message in case of failures and does so with proper localization. Unit-tests were adjusted accordingly.

- The conference group handler doesn't handle error codes anymore, related unit-tests were also removed.

- The HandledCall object was modified to cope with the new CallScreen.showStatusMessage() l10n id & args form. Unit-tests were adjusted accordingly.

[1] https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices#Writing_APIs_that_operate_on_L10nIDs

Comment 5

[Tamara Hills [:thills]]

Comment on attachment 8613545 [details] [review]
[gaia] gabrielesvelto:bug-1043165-call-promise-error > mozilla-b2g:master

Hi Gabriele,

This looks good.  I think it's much nicer to use the promise.  I did some testing as well.

Thanks,

-tamara

Comment 6

[Gabriele Svelto [:gsvelto]]

Thanks Tamara! Ready to land

Comment 7

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#rsnN-AV9TkeBdu3uB6sR8Q

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 8

[Gabriele Svelto [:gsvelto]]

Merged manually to  gaia/master 330b6825fca18b2183fb8d7af5cb726724f48dd9 because auto-lander is not working for me:

https://github.com/mozilla-b2g/gaia/commit/330b6825fca18b2183fb8d7af5cb726724f48dd9

Try run is here:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=26206596b996b9c100b63fe5251ef19131f39480