1125024 - [Telephony] Use nsIGonkTelephonyService.notifyCallStateChanged to replace notifyCallDisconnected

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

I think notifyCallDisconnected(call) could be replace by notifyCallStateChanged(call) with call.state == DISCONNECTED.

The reasons why I'd like to do this are:
- 1. To simplify and reduce the interface.
- 2. It's not symmetric. We provide a special interface for removing a call but we don't have a similar one for adding a new call.

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

NI hsinyi for her opinion.

Comment 2

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

This makes sense to me!

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Remove notifyCallDisconnected

I forgot that there is no CALL_STATE_DISCONNECTED in ril.  So I chose to use CALL_STATE_UNKNOWN.  We also use the same state for conferenceCallState to represent something is 'not existing'.

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: #2 Remove notifyCallDisconnected

Comment 5

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 8554355 [details] [diff] [review]
#2 Remove notifyCallDisconnected

Review of attachment 8554355 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/gonk/TelephonyService.js
@@ +270,5 @@
>  
>    _convertRILCallState: function(aState) {
>      switch (aState) {
>        case RIL.CALL_STATE_UNKNOWN:
> +        return nsITelephonyService.CALL_STATE_DISCONNECTED;

This change works fine for a single call, but it sort of changes "conference call" behaviour.
To not require changes on gaia or qcril, I'd suggest either 
1) map nsITelephonyService.CALL_STATE_DISCONNECTED to an empty string in [1], or
2) introduce RIL.CALL_STATE_DISCONNECTED  

How do you think? thank you!

[1] https://dxr.mozilla.org/mozilla-central/source/dom/telephony/TelephonyCallGroup.cpp?from=TelephonyCallGroup.cpp#93

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

I am going to do a change that introducing nsIGonkTelephonyService.notifyCurrentCalls to replace both 
notifyCallStateChanged and notifyCallDisconnected.  With that change, this bug is not needed.  So, set it to WONTFIX.