1125026 - [NFC] Shrinking UI is blank when try to share received contact or file which opened from notification

Status: VERIFIED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Alison Shiue]

Attachment: blank_shrinking_UI .png

Gaia-Rev        237008137f6d72b9cad25ff4faff14ff2c40ac63
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/be24dd482a83
Build-ID        20150122162504
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150122.194331
FW-Date         Thu Jan 22 19:43:41 EST 2015
Bootloader      L1TC000118D0

STR:
1. Enable NFC on two phones
2. Phone A receive an image via bluetooth (or receive a contact)
3. Open the image(or contact) via notification
4. Tap 2 phones together
5. Check the shrinking UI

Expected result:
Shrinking UI shows correctly

Actual result:
Shrinking UI is blank, please refer the attached screenshot.

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: regression

Comment 2

[Brogan Zumwalt [Inactive]]

Unable to provide regression window as issue occurs on first mozilla-central-flame-kk-eng build available on PVT server. 

Device that has opened bluetooth received image displays a blank square on UI when NFC pairing is attempted.

While shallow flash central engineering builds are available, testing on these is blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=1094527#c10 so that only Full flash builds can be used.

Device: Flame 2.2
Build ID: 20141106040023
Gaia: 068b9711277b06c7d633517f9e1fcb5624bb39b3
Gecko: a074c0112919
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Alive,
could I have your review on this patch?
Thanks.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8557860 [details] [review]
PR to master

this.frontWindow.isActive() otherwise the baseWindow will never hide overlay while frontWindow is closing

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8557860 [details] [review]
PR to master

Thanks advice!
patch is updated.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Master:
https://github.com/mozilla-b2g/gaia/commit/fa5075fc8beff5ed183cebc8ae1595d8dfee591e

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8557860 [details] [review]
PR to master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Not a regression nor a feature.
[User impact] if declined:
User would see gallery app becoming blank when tilting down. And it also fix that, if user launch a sub window and go to cardview, we'll show the top window's screenshot after this patch.
[Testing completed]:
Yes, I've checked manually and written unit test to cover this fail.
[Risk to taking this patch] (and alternatives if risky):
I don't see risk if merged to 2.2 branch.
[String changes made]:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/e827781324cbde91d2434b388f5dead3303a85ee

Comment 9

[Alison Shiue]

Verified on
[2.2]
Gaia-Rev        21cce750c095a3f815275fe5439fa9dbfe3dfc6b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/41ccc5328740
Build-ID        20150209162506
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150209.194557
FW-Date         Mon Feb  9 19:46:08 EST 2015
Bootloader      L1TC000118D0


[3.0]
Gaia-Rev        0cf517083f7eb5fc269e1236edba50534f65e3cd
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2cb22c058add
Build-ID        20150209160204
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150209.193059
FW-Date         Mon Feb  9 19:31:10 EST 2015
Bootloader      L1TC000118D0