1125041 - Transceive function does not work on NFC_A tag

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Dimi Lee [:dimi]]

Transceive function does not work on NFC_A tag, the root cause is that nfcd did not handle connect correctly.

Comment 1

[Dimi Lee [:dimi]]

Attachment: pull request to mozilla-b2g/platform_system_nfcd v1

Hi Yoshi,
The root cause is that the check in handleTagTransceiveResponse in NfcService.cpp is incorrect. Originally the tag technology in nfcd is a little bit mess so i also clean it up.

Combine tag technology defined in NfcGonkMessage and interface/TagTechnology
so for nci internal use of tag technology should be |enum TechnologyType|.
for general tag type will then be |enum TagTechnology|

Comment 2

[Dimi Lee [:dimi]]

Comment on attachment 8553590 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v1

Will work on bug 1089658 first then rebase on it

Comment 3

[Dimi Lee [:dimi]]

Comment on attachment 8553590 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v1

Set r? to yoshi because actually this bug is not really related to NFC_A, this is an internal bug of nfcd so this patch should also be uplift to 2.2

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/platform_system_nfcd/commit/13374490fc0c989347448f0b2d6b220adff5e630

Comment 5

[Dimi Lee [:dimi]]

Attachment: pull request to mozilla-b2g/platform_system_nfcd 2.2

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

v2.2 
https://github.com/mozilla-b2g/platform_system_nfcd/commit/c7ac4afbee0f80c5977d9ccc2d7a5c091fa85b85