1125070 - [RTL][Settings]The app icons in Location Accuracy list is not mirrored.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Sue]

Attachment: appicons.png

[1.Description]:
[RTL][Settings]Launch Settings -> Privacy Panel -> Location Accuracy -> Add exceptions, the app icons in Location Accuracy list is not mirrored.
Found time:15:10
See attachment:appicons.png and logcat_1510.txt

[2.Testing Steps]: 
Prerequisite: Set the system language as Arabic.
1. Launch Settings.
2. Select Privacy Panel -> Location Accuracy -> Add exceptions.
3. Observe the list.

[3.Expected Result]: 
3. The app icons in list should be mirrored.

[4.Actual Result]: 
3. The app icons in Location Accuracy list is not mirrored.

[5.Reproduction build]: 
Flame 2.2 build:
Gaia-Rev        e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4a90da67661e
Build-ID        20150122002808
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150122.041326
FW-Date         Thu Jan 22 04:13:37 EST 2015
Bootloader      L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Sue]

Attachment: logcat_1510.txt

Comment 2

[Martin Shuman [:Marty]]

Adding privacy keyword.

Comment 3

[Dylan Oliver [:doliver]]

This is Kaze's fault.

Comment 4

[Fabien Cazenave [:kaze]]

I confirm, shame on me!

Comment 5

[Sue]

The apps in Applications and Permissions items also have this problem.
STR:
1. Launch Settings.
2. Select Privacy Panel -> Transparency Control -> Applications or Permissions.
**All apps in item which under Applications and Permissions are not mirrored.

Comment 6

[howie [:howie]]

Hi Fabien, you still working on this? thanks.

Comment 7

[Fabien Cazenave [:kaze]]

Hi Howie, feel free to steal this bug if you want. I have a couple priorities to address first, so I’m not likely to work on this on the next day or two.

Comment 8

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I can help this one.

Comment 9

[GitHub Autolander Bot]

Attachment: [PullReq] EragonJ:bug-1125070 to mozilla-b2g:master

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8561816 [details] [review]
[PullReq] EragonJ:bug-1125070 to mozilla-b2g:master

Hi Marta,

would you mind help me check this patch ? Thanks !

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks all, this patch was merged into Gaia/master : https://github.com/mozilla-b2g/gaia/commit/28bd6232944f7266fab29c99c917f4df119659ae

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8561816 [details] [review]
[PullReq] EragonJ:bug-1125070 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): no
[User impact] if declined: for RTL users, app icons would get overlapped with the the other stuffs on the screen.
[Testing completed]: no, only css change.
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: no

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/a01304b1a3370551164fe736230af6f6ca80a860

Comment 14

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 and Flame 2.2 builds.

Actual Results: The icons are correctly mirrored in RTL languages.

Environmental Variables:
Device: Flame 3.0 KK (319MB) (Full Flash)
BuildID: 20150220010206
Gaia: e4f7c67378e33e83f88d38ddb4a6c2cabf1423c3
Gecko: 1b4c5daa7b7a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Environmental Variables:
Device: Flame 2.2 KK (319MB) (Full Flash)
BuildID: 20150220002501
Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4
Gecko: b864abe1c6b3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 15

[Sue]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15739/