Closed Bug 1125093 Opened 10 years ago Closed 10 years ago

Switch Karma to run tests in Firefox instead of PhantomJS

Categories

(www.mozilla.org :: Bedrock, defect)

Production
x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: agibson, Assigned: agibson)

Details

(Whiteboard: [kb=1640192])

Attachments

(1 file)

Our current Jasmine JS tests for bedrock use Karma test runner and PhantomJS.

PhantomJS is a headless web browser which runs on an increasingly outdated version of Webkit. This is currently preventing us from writing tests against code that use even basic ES5 features, like .bind() - without resorting to including JS polyfills in our tests.

Karma supports spawning various different browsers and environments for testing, so this is a bug to track switching to running Firefox instead. 

Longer term, it may be good to look at using SlimerJS - but currently there seems to be an issue when using it with Karma [1]

[1] Karma fails to kill SlimerJS - https://github.com/karma-runner/karma-slimerjs-launcher/issues/1
Whiteboard: [kb=1640192]
Assignee: nobody → agibson
Status: NEW → ASSIGNED
Attached file GitHub pull request
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a2e348b3007001aa330fe7f7b0baca6652467101
[fix bug 1125093] Switch Karma to run tests in Firefox instead of PhantomJS

https://github.com/mozilla/bedrock/commit/b321ecffc82b43441f1990874dd33acd4aa1668d
Merge pull request #2679 from alexgibson/bug-1125093-karma-runner-firefox

[fix bug 1125093] Switch Karma to run tests in Firefox instead of PhantomJS
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: