1125108 - Disable blanket by default in watcher

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
1. have the test-agent browser + server running in background
2. save a syntax error in a file that's monitored by the test-agent

Expected:
* an error shows up in the console
* when I save the file removing the syntax error, it's now run again

Actual:
* an error shows up in the console
* when I save the file removing the syntax error, nothing runs. And actually the same happens for all files. I need to reload the test-agent window to make it work again.


The blanket error is:

JavaScript error: app://sms.gaiamobile.org/common/vendor/blanket/blanket.js?time=1422018172628, line 41: Error: Line 41: Unexpected token :


I think we need to catch those errors so that the test-agent can run subsequent tests.

Comment 1

[Julien Wajsberg [:julienw]]

Hey Ricky, do you have an idea for this?

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Werid :(

My test-agent can automatically re-trigger when I save the file with removing a syntax error.

In order to catch those errors, I think we can add Error.prototype.stack [1] to do so. However, I hope that patch will not change anything in blanket.js.

[1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/Stack

Comment 3

[Julien Wajsberg [:julienw]]

Humm if it works for you maybe I'm doing something wrong. I'll look further.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] RickyChien:bug-1125108 > mozilla-b2g:master

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Attachment: Js-test-agent PR

Hi Julien, so far unit testing is hard to debug for a while since enabling blanket by default output so many dara-uri instead of proper error messages.

I'd like to disable it for reducing such trouble. Please review it kindly thanks! =)

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 8565399 [details] [review]
Js-test-agent PR

This fixes the issue for me but because it doesn't fix the root issue we might want to land this in a separate bug?

r=me for this patch

Comment 7

[Ricky Chien [:rickychien] (inactive)]

I'd like to address the root issue in another bug because it seems not so easy to fix if it turns out that we have to patch blanket.js.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia-node-modules] RickyChien:bug-1125108 > mozilla-b2g:master

Comment 9

[Ricky Chien [:rickychien] (inactive)]

Landed in master:

gaia: https://github.com/mozilla-b2g/gaia/commit/123e7e33965c5bfca3238913f2b2828fe77eee9e

js-test-agent: https://github.com/mozilla-b2g/js-test-agent/commit/45d78a8231cad1a261d2401435d5b1e1eeff8083

gaia-node-modules: https://github.com/mozilla-b2g/gaia-node-modules/commit/800b5b4505221e620b9a68ab966ad562827e3eaf

Comment 10

[Julien Wajsberg [:julienw]]

(In reply to Ricky Chien [:rickychien] from comment #7)
> I'd like to address the root issue in another bug because it seems not so
> easy to fix if it turns out that we have to patch blanket.js.

2 thoughts:
* IMO it would have been easier to just file a separate bug to disable blanket and have your patch there... Now I need to clone this bug...

* I think we just need to try/catch somewhere in our code when we instrument using blanket before launching the tests.

Comment 11

[Johan Lorenzo [:jlorenzo] - On PTO - Back on July 28th]

Renaming the bug based on comment and the commit messages.