1125138 - Move TestTimeStamp.cpp to gtest and enable it; r=froydnj

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[(no longer active)]

Attachment: Move TestTimeStamp.cpp to gtest and enable it

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8553736 [details] [diff] [review]
Move TestTimeStamp.cpp to gtest and enable it

Review of attachment 8553736 [details] [diff] [review]:
-----------------------------------------------------------------

Can you please make sure hg interprets this as a move in the actual commit, rather than an add/remove?

::: xpcom/tests/gtest/TestTimeStamp.cpp
@@ +31,5 @@
> +    EXPECT_FALSE(TimeDuration::FromSeconds(1) >= TimeDuration::FromSeconds(2));
> +
> +    TimeStamp ts;
> +    EXPECT_TRUE(ts.IsNull());
> +    

Nit: trailing whitespace.

Comment 3

[(no longer active)]

(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #2)
> Can you please make sure hg interprets this as a move in the actual commit,
> rather than an add/remove?

Painful :(

https://hg.mozilla.org/integration/mozilla-inbound/rev/67496f44f461

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7971981a6000 for checktest failuresL

https://treeherder.mozilla.org/logviewer.html#?job_id=5930134&repo=mozilla-inbound

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b3911fe7821