1125272 - crash in mozilla::CDMCaps::Lock()

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: new crash for 37a2


This bug was filed from the Socorro interface and is 
report bp-0a7d2c45-caf7-4665-b170-ee5a22150117.
=============================================================


Frame 	Module 	Signature 	Source
0 	libxul.so 	mozilla::CDMCaps::Lock() 	xpcom/glue/Mutex.h
1 	libxul.so 	mozilla::image::imgFrame::GetAnimationData() const 	xpcom/glue/Monitor.h
2 	libxul.so 	mozilla::image::FrameAnimator::GetTimeoutForFrame(unsigned int) const 	image/src/FrameAnimator.cpp
3 	libxul.so 	mozilla::image::RasterImage::StartAnimation() 	image/src/RasterImage.cpp
4 	libxul.so 	mozilla::image::ImageResource::EvaluateAnimation() 	image/src/Image.cpp
5 	libxul.so 	mozilla::image::RasterImage::RequestRefresh(mozilla::TimeStamp const&) 	image/src/RasterImage.cpp
6 	libxul.so 	nsRefreshDriver::Tick(long long, mozilla::TimeStamp) 	layout/base/nsRefreshDriver.cpp
7 	libxul.so 	mozilla::RefreshDriverTimer::Tick() 	layout/base/nsRefreshDriver.cpp
8 	libxul.so 	nsTimerImpl::Fire() 	xpcom/threads/nsTimerImpl.cpp
9 	libxul.so 	nsTimerEvent::Run() 	xpcom/threads/nsTimerImpl.cpp
10 	libxul.so 	nsThread::ProcessNextEvent(bool, bool*) 	xpcom/threads/nsThread.cpp
11 	libxul.so 	NS_ProcessNextEvent(nsIThread*, bool) 	xpcom/glue/nsThreadUtils.cpp
12 	libxul.so 	mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp
13 	libxul.so 	MessageLoop::RunInternal() 	ipc/chromium/src/base/message_loop.cc
14 	libxul.so 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc
15 	libxul.so 	nsBaseAppShell::Run() 	widget/nsBaseAppShell.cpp
16 	libxul.so 	nsAppStartup::Run() 	toolkit/components/startup/nsAppStartup.cpp
17 	libxul.so 	XREMain::XRE_mainRun() 	toolkit/xre/nsAppRunner.cpp
18 	libxul.so 	XREMain::XRE_main(int, char**, nsXREAppData const*) 	toolkit/xre/nsAppRunner.cpp
19 	libxul.so 	XRE_main 	toolkit/xre/nsAppRunner.cpp
20 	libxul.so 	GeckoStart 	toolkit/xre/nsAndroidStartup.cpp
21 	libmozglue.so 	Java_org_mozilla_gecko_mozglue_GeckoLoader_nativeRun 	mozglue/android/APKOpen.cpp
Ø 22 	libdvm.so 	libdvm.so@0x1eb0e 	
Ø 23 	mnt@[e-mail][e-mail] 	mnt@[e-mail][e-mail]@0x3b33a3 	
Ø 24 	dalvik-heap (deleted) 	dalvik-heap (deleted)@0x5600d6 	
Ø 25 	dalvik-heap (deleted) 	dalvik-heap (deleted)@0x5d1a8e 	
Ø 26 	libdvm.so 	libdvm.so@0x4f459 	
Ø 27 	mnt@[e-mail][e-mail] 	mnt@[e-mail][e-mail]@0x3b33a1 	
28 	libmozglue.so 	Java_org_mozilla_gecko_mozglue_GeckoLoader_loadNSSLibsNative 	mozglue/android/APKOpen.cpp
29 		@0x25afffff 	
30 	libmozglue.so 	Java_org_mozilla_gecko_mozglue_GeckoLoader_loadNSSLibsNative 	mozglue/android/APKOpen.cpp

Comment 1

[Lawrence Mandel [:lmandel] (use needinfo)]

Seth - Can you take this bug about a crash in ImageLib?

Comment 2

[Seth Fowler [:seth] [:s2h]]

Yes, I'll take it.

Comment 3

[Seth Fowler [:seth] [:s2h]]

This is fixed by bug 1079627, which I'm going to request uplift for very soon.

Comment 4

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Socorro [1] shows only 3 crashes over the past 4 weeks in Firefox 38 Nightly in builds after this landed (January 16th), while Aurora 37 shows some 250 crashes with this signature. This looks good... I'm not sure whether we were expecting 0 crashes in Nightly, or the very low number is OK.  

[1] - https://crash-stats.mozilla.com/report/list?product=FennecAndroid&range_unit=days&range_value=28&signature=mozilla%3A%3ACDMCaps%3A%3ALock%28%29#tab-reports

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Seth - With bug 1079627 having been uplifted to 37, can this bug be resolved?

Comment 6

[Seth Fowler [:seth] [:s2h]]

Yes, it should be resolved.

I'm not sure about the few remaining crashes on Nightly. I looked at the stack for the one Florin linked and the signature looks different, so it's probably actually a different bug.

I'm going to resolve this one, but please leave the needinfo on and I'll file a new bug for the other issue as soon as I can.