KidFox: Restricted profiles - Hide all developer tools and related UI

VERIFIED FIXED in Firefox 42

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: jchaulk, Assigned: sebastian)

Tracking

Trunk
Firefox 42
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Blocks: FFB
OS: Windows 8.1 → Android
Hardware: x86_64 → All
Version: unspecified → Trunk
(Reporter)

Updated

4 years ago
Blocks: kidfox-v1
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
WIP patch based on changes in bug 1187260.
Final version for review.
Attachment #8639234 - Attachment is obsolete: true
Attachment #8639866 - Flags: review?(ally)
Comment on attachment 8639866 [details] [diff] [review]
1125288-developer-tools.patch

Review of attachment 8639866 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by r+ :)

::: mobile/android/base/preferences/GeckoPreferences.java
@@ +484,5 @@
> +                if (header.id == R.id.pref_header_language && !localeSwitchingIsEnabled) {
> +                    // If locale switching is disabled, remove the section
> +                    // entirely. This logic will need to be extended when
> +                    // content language selection (Bug 881510) is implemented.
> +                    iterator.remove();

Just to confirm, did you have to change the iterator syntax here to avoid a concurrent modification exception?
Attachment #8639866 - Flags: review?(ally) → review+
heh, looks like you don't need me for this one. :)
(In reply to :Margaret Leibovic from comment #3)
> Just to confirm, did you have to change the iterator syntax here to avoid a
> concurrent modification exception?

Yeah, previously we jumped out of the loop after modifying the list. Now I want to continue iterating over the modified list.
url:        https://hg.mozilla.org/integration/fx-team/rev/06f2c8aca1e37821e6a0827c9540a63239dbfdb9
changeset:  06f2c8aca1e37821e6a0827c9540a63239dbfdb9
user:       Sebastian Kaspari <s.kaspari@gmail.com>
date:       Thu Jul 30 19:48:38 2015 +0200
description:
Bug 1125288 - Restricted profiles: Hide all developer tools and related UI. r=margaret
https://hg.mozilla.org/mozilla-central/rev/06f2c8aca1e3
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42

Comment 8

4 years ago
Verified as fixed on latest Aurora
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.