1125396 - TypeError: message.target.messageManager is undefined in ReaderParent

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Margaret Leibovic]

*************************
A coding exception was thrown in a Promise resolution callback.
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
Full message: TypeError: message.target.messageManager is undefined
Full stack: ReaderParent.receiveMessage/<@resource:///modules/ReaderParent.jsm:48:11
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:870:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:749:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:691:37
*************************

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1125396/margaret

/r/2969 - Bug 1125396 - Check to make sure messageManager exists before sending message with article data

Pull down this commit:

hg pull review -r 3924447fd75188e38d7fb1c4bbb6bc90bf9da365

Comment 2

[:Margaret Leibovic]

Comment on attachment 8554030 [details]
MozReview Request: bz://1125396/margaret

/r/2969 - Bug 1125396 - Check to make sure messageManager exists before sending message with article data

Pull down this commit:

hg pull review -r 3924447fd75188e38d7fb1c4bbb6bc90bf9da365

Comment 3

[:Margaret Leibovic]

I saw this while working on my browser-chrome test, and I think the speed with which the test was closing a tab tickled this edge case. I can't reproduce the problem with the patch applied, so I think this fixes it.

I also think this is a valid edge-case, so I don't believe this is just a band-aid to another problem.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8554030 [details]
MozReview Request: bz://1125396/margaret

https://reviewboard.mozilla.org/r/2967/#review2449

Ship It!

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/67d1b69adbeb

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/67d1b69adbeb

Comment 8

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1125396 - Check to make sure messageManager exists before sending message with article data