1125405 - Update HTML files in the webapp to use <meta> instead of manifest.webapp for l10n meta

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

Follow up to bug 1125183.

Since bug 1115807 landed, we expect apps to provide l10n meta information in <meta> tags instead of a link to manifest.webapp.

In loop there are two HTML files:
 - call.html
 - index.html

Both have <link rel="manifest"/>.

This link should be removed and instead you should have:

<meta name="defaultLanguage" content="en-US">
<meta name="availableLanguages" content="de, en-US, es, it">

which matches the locales in-tree.

Comment 1

[Mark Banner (:standard8)]

Hi gandalf, where are you looking at the loop files?

We've never had a call.html iirc, and the index.html is already using manifest tags; http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/standalone/content/index.html?force=1

So I'm a bit confused as to what you are looking at.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ugh, it's for https://github.com/mozilla-b2g/firefoxos-loop-client/

Michael, should it be a different component or should I report it there?

Comment 3

[Mark Banner (:standard8)]

Ah, you want the Firefox OS product then.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

:gandalf, you could go for the bug if you want but I tell you some information about the FxOS Hello client app first. At the moment the app is supposed to be installed on FxOS v2.0 *only* so unless both bugs 1115807 and 1125183 get into FxOS v2.0 we shouldn't add the changes you suggest. Moreover as I see we should update our copy of the ln10.js lib as the app being installed as a third party app doesn't the use the l10n.js from shared. Anyway, are you sure both bugs 1115807 and 1125183 will be part of FxOS v2.0 release eventually?

Adding Antonio and Maria to the loop in case they want comment something about future versions of the FxOS Hello app.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #4)
> :gandalf, you could go for the bug if you want but I tell you some
> information about the FxOS Hello client app first. At the moment the app is
> supposed to be installed on FxOS v2.0 *only* so unless both bugs 1115807 and
> 1125183 get into FxOS v2.0 we shouldn't add the changes you suggest.

Absolutely.

> Moreover as I see we should update our copy of the ln10.js lib as the app
> being installed as a third party app doesn't the use the l10n.js from
> shared. Anyway, are you sure both bugs 1115807 and 1125183 will be part of
> FxOS v2.0 release eventually?

I'm sure they will not be.

The whole bug has been reported because we got a report that loop doesn't work with changes we landed in l10n.js for fxos 2.2. (manifest->meta).

I didn't know that the target is 2.0.

I guess it is a invalid then. Sorry for bothering you!