1125415 - talos fails to print local.json when in --develop mode

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

it appears we are missing out on printing out local.json (we do get local.out) when running talos.

talos -e /home/jmaher/mozilla/mozilla-inbound/obj-x86_64-unknown-linux-gnu/dist/bin/firefox -a tsvgx --develop


Completed test tsvgx: 
		Stopped Fri, 23 Jan 2015 18:14:33
cycle time: 00:05:59
qm-pxp01: 
		Stopped Fri, 23 Jan 2015 18:14:33
INFO : Outputting talos results => {'results_urls': ['local.out'], 'datazilla_urls': ['local.json']}
DEBUG : Working with test: tsvgx
Generating results file: tsvgx: 
		Started Fri, 23 Jan 2015 18:14:33
Generating results file: tsvgx: 
		Stopped Fri, 23 Jan 2015 18:14:33
INFO : Outputting datazilla results to local.json
Traceback (most recent call last):
  File "run_tests.py", line 305, in <module>
    main()
  File "run_tests.py", line 302, in main
    sys.exit(run_tests(parser))
  File "run_tests.py", line 276, in run_tests
    talos_results.output(results_urls, **results_options)
  File "/home/jmaher/mozilla/talos/talos/results.py", line 76, in output
    _output.output(results, url, tbpl_output)
  File "/home/jmaher/mozilla/talos/talos/output.py", line 420, in output
    utils.info("TALOSDATA: %s" % json.dumps(results.datasets()))
  File "/usr/local/lib/python2.7/dist-packages/dzclient/client.py", line 136, in datasets
    'revision': self.revision[:50],
TypeError: 'NoneType' object has no attribute '__getitem__'
jmaher@jmaher-ThinkPad-X230:~/mozilla/talos/talos$

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I have a hard time reproducing this.  I suspect when I test with `which firefox`, I have to locally hack out the revision and repository from the information since it isn't available, that would explain what probably happened here.

Comment 2

[Ankit Goyal]

Talos is using mozversion to get repository and sourcestamp(revision).
And mozversion fetches this data from application.ini present in firefox parent directory.
See application.ini of nighty build and firefox release install(may be in /usr/lib/firefox), some required metadata is absent in firefox release.

What i think we can do here is:
1. Put check in datazilla
2. Put a dummy value in browser_config['sourcestamp']

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Ankit, thanks for the info.  I keep running into a case locally where there is no application.ini.  I think your idea for #2 is a good one, want to take a stab at it?

Comment 4

[Ankit Goyal]

Attachment: Bug 1125415 - talos fails to print local.json when in --develop mode. r=jmaher

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8555667 [details] [diff] [review]
Bug 1125415 - talos fails to print local.json when in --develop mode. r=jmaher

Review of attachment 8555667 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/build/talos/rev/9e02bbf80240

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Thanks Ankit!