1125497 - Remove redundant TelemetryStopwatch.jsm import from browser-gestureSupport.js

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

At the top of browser/base/content/browser-gestureSupport.js, we import TelemetryStopwatch.jsm because some code in browser-gestureSupport.js wants to use TelemetryStopwatch. We can remove this import, because browser.js already imports TelemetryStopwatch.jsm (http://hg.mozilla.org/mozilla-central/annotate/c0f88b376e33/browser/base/content/browser.js#l107).

Comment 1

[Abhishek Bhattacharya [:babhishek21]]

Will simply removing the import call do? Am I also supposed to check for dependencies/conflicts?

Comment 2

[Dão Gottwald [:dao]]

(In reply to Abhishek Bhattacharya [:babhishek21] from comment #1)
> Will simply removing the import call do?

yep

> Am I also supposed to check for
> dependencies/conflicts?

nope

Comment 3

[Alexander Dimitrov [:alexxdim94]]

Can I work on this? I'm looking for my first bug! :)

Comment 4

[Alexander Dimitrov [:alexxdim94]]

Attachment: bug-1125497-fix.diff

Comment 5

[Abhishek Bhattacharya [:babhishek21]]

(In reply to Alexander Dimitrov from comment #4)
> Created attachment 8554261 [details] [diff] [review]
> bug-1125497-fix.diff

Looks good. Wait for the review+.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8554261 [details] [diff] [review]
bug-1125497-fix.diff

Thanks!

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/0e1056fb8804

Comment 8

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/0e1056fb8804