Closed Bug 1125497 Opened 8 years ago Closed 8 years ago
Remove redundant Telemetry
Stopwatch .jsm import from browser-gesture Support .js
At the top of browser/base/content/browser-gestureSupport.js, we import TelemetryStopwatch.jsm because some code in browser-gestureSupport.js wants to use TelemetryStopwatch. We can remove this import, because browser.js already imports TelemetryStopwatch.jsm (http://hg.mozilla.org/mozilla-central/annotate/c0f88b376e33/browser/base/content/browser.js#l107).
Will simply removing the import call do? Am I also supposed to check for dependencies/conflicts?
(In reply to Abhishek Bhattacharya [:babhishek21] from comment #1) > Will simply removing the import call do? yep > Am I also supposed to check for > dependencies/conflicts? nope
Can I work on this? I'm looking for my first bug! :)
(In reply to Alexander Dimitrov from comment #4) > Created attachment 8554261 [details] [diff] [review] > bug-1125497-fix.diff Looks good. Wait for the review+.
Attachment #8554261 - Flags: review?(gavin.sharp) → review?(dao)
Comment on attachment 8554261 [details] [diff] [review] bug-1125497-fix.diff Thanks!
Attachment #8554261 - Flags: review?(dao) → review+
Assignee: nobody → alexxander.dimitrov
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
You need to log in before you can comment on or make changes to this bug.