1125501 - TypeError: impl is null network-monitor.js:97:6

Status: RESOLVED WORKSFORME

(Firefox :: Extension Compatibility, defect)

Description

[Alice0775 White]

Steps to reproduce:
1. Install https://addons.mozilla.org/en-US/firefox/addon/foxyproxy-standard/ and restart
2. Open Browser Console (Ctrl+Shift+J)
3. Right click on toolbar icon. And choose "Use proxies based on their pre-defined patterns and priorities" to enable add-on
4. Open https://addons.mozilla.org/en-US/firefox/?utm_source=snippet&utm_medium=snippet&utm_campaign=addons

Actual Results:
TypeError: impl is null network-monitor.js:97:6


Regression window
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93976782a910
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 ID:20150122052129
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/174cc41e7e03
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 ID:20150122054047
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=93976782a910&tochange=174cc41e7e03

Triggered by:
2d8d90eaab6e	J. Ryan Stinnett — Bug 731318 - Show transferred size in Net Monitor. r=vporof

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Does the addon still function as expected?

Comment 2

[Alice0775 White]

(In reply to J. Ryan Stinnett [:jryans] from comment #1)
> Does the addon still function as expected?

No, it is not working

Comment 3

[Alice0775 White]

Probably,  Bug 1125372.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Alice0775 White from comment #3)
> Probably,  Bug 1125372.

Can you confirm that it now works correctly after bug 1125372 is resolved?

I just want to be sure that this bug is just about a log message and not functionality.

Comment 5

[Alice0775 White]

(In reply to J. Ryan Stinnett [:jryans] from comment #4)
> (In reply to Alice0775 White from comment #3)
> > Probably,  Bug 1125372.
> 
> Can you confirm that it now works correctly after bug 1125372 is resolved?
> 
> I just want to be sure that this bug is just about a log message and not
> functionality.

FoxyProxy does not work. Bug 1125372 does not fix.... 

Tested with latest m-c tinderbox
https://hg.mozilla.org/mozilla-central/rev/fc21937ca612
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 ID:20150128052133

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Alice0775 White from comment #5)
> (In reply to J. Ryan Stinnett [:jryans] from comment #4)
> > (In reply to Alice0775 White from comment #3)
> > > Probably,  Bug 1125372.
> > 
> > Can you confirm that it now works correctly after bug 1125372 is resolved?
> > 
> > I just want to be sure that this bug is just about a log message and not
> > functionality.
> 
> FoxyProxy does not work. Bug 1125372 does not fix.... 
> 
> Tested with latest m-c tinderbox
> https://hg.mozilla.org/mozilla-central/rev/fc21937ca612
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
> ID:20150128052133

Here are the results of my local testing with a recent copy of fx-team (2015-01-28) (http://hg.mozilla.org/integration/fx-team/rev/42750f461e95) and FoxyProxy 4.5:

* Choosing a proxy to use "for all URLs" works, but "Use proxies based on their patterns" does not appear to work
* Reverting bug 731318 does stop the TypeError from being logged, however it does not fix "Use proxies based on their patterns"

I am happy to clean up the TypeError here, but it appears bug 731318 is not the root cause of FoxyProxy's broken functionality.

I did a minimal investigation of FoxyProxy which agrees with the FoxyProxy forum[1] that the functionality issue is caused by bug 436344, and it's likely that the FoxyProxy developers need to update the add-on to account for this change.

[1]: http://forums.getfoxyproxy.org/viewtopic.php?f=4&t=1251

Comment 7

[Alice0775 White]

See http://forums.mozillazine.org/viewtopic.php?f=38&t=2859425

version 2.2.4 Works fine.

Comment 8

[David Lawrence [:dkl]]

Mistakenly filed against Firefox 38 and should be instead 38 Branch. Sorry for the spam. dkl

Comment 9

[Stu Gese]

I have Firefox 40 Beta and still have this error.

FoxyProxy works in my setup (Use proxies based on their pre-defined patterns and priorities)