1125516 - Ensure Selection closed at start of attachCaret()

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[Mark Capella [:capella]]

Attachment: closeSelectionBeforeAttachCaret.diff

This is a followup we talked about back in bug 927882 comment #36 and bug 927882 comment #38 ... I wanted to wait until I could point to an actual issue caused by *not* doing the change.

There's a slight timing issue that leaves listeners attached to a page after SelectionHandler closes, which is harmless due to event-handler state-checking, but wastes cycles.

To trigger: 1) Long press into editable to startSelection, 2) tap into selection to attachCaret.

In some cases where IME auto-correct kicks in, we wind up closing the new caret and leaving the previous selection listeners.

Comment 1

[Mark Capella [:capella]]

push to try, hammer on rc7 ...
https://tbpl.mozilla.org/?tree=Try&rev=8097a9e3a746

Comment 2

[Mark Capella [:capella]]

Review nag ping?

Comment 3

[Mark Capella [:capella]]

try-push
https://tbpl.mozilla.org/?tree=Try&rev=1f1ccb1f0dd1

Comment 4

[Mark Capella [:capella]]

https://hg.mozilla.org/integration/fx-team/rev/30986ffaa731

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/30986ffaa731