1125592 - Fix -Wmaybe-uninitialized warning in security/manager/ssl/src/nsNSSASN1Object.cpp

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: Wuninitialized_nsNSSASN1Object.patch

getDERItemLength() can return error (len == -1) without initializing bytesUsed, so check for error before using bytesUsed:

security/manager/ssl/src/nsNSSASN1Object.cpp:131:22: warning: 'bytesUsed' may be used uninitialized in this function [-Wmaybe-uninitialized]

Comment 1

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 8554239 [details] [diff] [review]
Wuninitialized_nsNSSASN1Object.patch

Review of attachment 8554239 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the suggested change. Thanks for taking care of this!

::: security/manager/ssl/src/nsNSSASN1Object.cpp
@@ +131,1 @@
>      if ((len < 0) || ((data+len) > end))

Unfortunately 'data' is used in this expression. Let's do something like this:

if (len < 0) {
  return NS_ERROR_FAILURE;
}
data += bytesUsed;
if (data + len > end) {
  return NS_ERROR_FAILURE;
}

(although I suppose the other option is to use bytesUsed in the original expression)

Comment 2

[Chris Peterson [:cpeterson]]

Thanks. I landed the code you suggested:

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b207b997e4c

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b207b997e4c