1125640 - /usr/include/unicode/stringpiece.h:68:3: error: bad implicit conversion constructor for 'StringPiece'

Status: RESOLVED WORKSFORME

(Core :: General, defect)

Description

[Alex Xu]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20141102102333

Steps to reproduce:

Build gecko-dev HEAD on Gentoo with Clang 3.5.1.


Actual results:

11:11.13 In file included from /home/alex/gecko-dev/obj-x86_64-unknown-linux-gnu/layout/forms/Unified_cpp_layout_forms0.cpp:128:
11:11.13 In file included from /home/alex/gecko-dev/layout/forms/nsNumberControlFrame.cpp:9:
11:11.13 In file included from ../../dist/include/ICUUtils.h:18:
11:11.13 In file included from ../../dist/system_wrappers/unicode/unum.h:3:
11:11.13 In file included from /usr/include/unicode/unum.h:20:
11:11.13 In file included from /usr/include/unicode/uloc.h:25:
11:11.13 In file included from ../../dist/system_wrappers/unicode/uenum.h:3:
11:11.13 In file included from /usr/include/unicode/uenum.h:24:
11:11.13 In file included from /usr/include/unicode/strenum.h:14:
11:11.13 In file included from /usr/include/unicode/unistr.h:32:
11:11.13 /usr/include/unicode/stringpiece.h:68:3: error: bad implicit conversion constructor for 'StringPiece'
11:11.13   StringPiece(const char* str);
11:11.13   ^
11:11.13 /usr/include/unicode/stringpiece.h:68:3: note: consider adding the explicit keyword to the constructor
11:11.13 /usr/include/unicode/stringpiece.h:74:3: error: bad implicit conversion constructor for 'StringPiece'
11:11.13   StringPiece(const std::string& str)
11:11.13   ^
11:11.13 /usr/include/unicode/stringpiece.h:74:3: note: consider adding the explicit keyword to the constructor
11:11.13 In file included from /home/alex/gecko-dev/obj-x86_64-unknown-linux-gnu/layout/forms/Unified_cpp_layout_forms0.cpp:128:
11:11.13 In file included from /home/alex/gecko-dev/layout/forms/nsNumberControlFrame.cpp:9:
11:11.13 In file included from ../../dist/include/ICUUtils.h:18:
11:11.13 In file included from ../../dist/system_wrappers/unicode/unum.h:3:
11:11.14 In file included from /usr/include/unicode/unum.h:20:
11:11.14 In file included from /usr/include/unicode/uloc.h:25:
11:11.14 In file included from ../../dist/system_wrappers/unicode/uenum.h:3:
11:11.14 In file included from /usr/include/unicode/uenum.h:24:
11:11.14 In file included from /usr/include/unicode/strenum.h:14:
11:11.14 In file included from /usr/include/unicode/unistr.h:33:
11:11.14 /usr/include/unicode/bytestream.h:238:3: error: bad implicit conversion constructor for 'StringByteSink'
11:11.14   StringByteSink(StringClass* dest) : dest_(dest) { }
11:11.14   ^
11:11.14 /usr/include/unicode/bytestream.h:238:3: note: consider adding the explicit keyword to the constructor
11:11.14   ^                                                                                                                                                                                                                                                           [0/1840]
11:11.14 /usr/include/unicode/bytestream.h:238:3: note: consider adding the explicit keyword to the constructor
11:11.14 In file included from /home/alex/gecko-dev/obj-x86_64-unknown-linux-gnu/layout/forms/Unified_cpp_layout_forms0.cpp:128:
11:11.14 In file included from /home/alex/gecko-dev/layout/forms/nsNumberControlFrame.cpp:9:
11:11.14 In file included from ../../dist/include/ICUUtils.h:18:
11:11.14 In file included from ../../dist/system_wrappers/unicode/unum.h:3:
11:11.14 In file included from /usr/include/unicode/unum.h:20:
11:11.14 In file included from /usr/include/unicode/uloc.h:25:
11:11.14 In file included from ../../dist/system_wrappers/unicode/uenum.h:3:
11:11.14 In file included from /usr/include/unicode/uenum.h:24:
11:11.14 In file included from /usr/include/unicode/strenum.h:14:
11:11.14 /usr/include/unicode/unistr.h:2879:29: error: bad implicit conversion constructor for 'UnicodeString'
11:11.14   UNISTR_FROM_CHAR_EXPLICIT UnicodeString(UChar ch);
11:11.14                             ^
11:11.14 /usr/include/unicode/unistr.h:2879:29: note: consider adding the explicit keyword to the constructor
11:11.14 /usr/include/unicode/unistr.h:2890:29: error: bad implicit conversion constructor for 'UnicodeString'
11:11.14   UNISTR_FROM_CHAR_EXPLICIT UnicodeString(UChar32 ch);
11:11.14                             ^
11:11.14 /usr/include/unicode/unistr.h:2890:29: note: consider adding the explicit keyword to the constructor
11:11.14 /usr/include/unicode/unistr.h:2902:31: error: bad implicit conversion constructor for 'UnicodeString'
11:11.14   UNISTR_FROM_STRING_EXPLICIT UnicodeString(const UChar *text);
11:11.14                               ^
11:11.14 /usr/include/unicode/unistr.h:2902:31: note: consider adding the explicit keyword to the constructor
11:11.14 /usr/include/unicode/unistr.h:2981:31: error: bad implicit conversion constructor for 'UnicodeString'
11:11.14   UNISTR_FROM_STRING_EXPLICIT UnicodeString(const char *codepageData);
11:11.14                               ^
11:11.14 /usr/include/unicode/unistr.h:2981:31: note: consider adding the explicit keyword to the constructor
11:11.14 7 errors generated.
11:11.14 
11:11.14 In the directory  /home/alex/gecko-dev/obj-x86_64-unknown-linux-gnu/layout/forms
11:11.14 The following command failed to execute properly:
11:11.14 /usr/bin/ccache clang++ -o Unified_cpp_layout_forms0.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /home/alex/gecko-dev/config/gcc_hidden.h -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_GLUE_IN_PROGRAM -DAB_CD=en-US
 -DNO_NSPR_10_SUPPORT -I/home/alex/gecko-dev/layout/forms -I. -I/home/alex/gecko-dev/layout/forms/../../editor/libeditor -I/home/alex/gecko-dev/layout/forms/../../editor/txmgr -I/home/alex/gecko-dev/layout/forms/../base -I/home/alex/gecko-dev/layout/forms/../generic -I/h
ome/alex/gecko-dev/layout/forms/../xul -I/home/alex/gecko-dev/dom/base -I/home/alex/gecko-dev/dom/html -I../../dist/include -I/home/alex/gecko-dev/obj-x86_64-unknown-linux-gnu/dist/include/nspr -I/home/alex/gecko-dev/obj-x86_64-unknown-linux-gnu/dist/include/nss -fPIC -Q
unused-arguments -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/Unified_cpp_layout_forms0.o.pp -Qunused-arguments -Qunused-arguments -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Werror=endif-labels -Werror=int-to-pointer-cas
t -Werror=missing-braces -Werror=parentheses -Werror=pointer-arith -Werror=return-type -Werror=sequence-point -Werror=switch -Werror=trigraphs -Werror=type-limits -Werror=unused-label -Werror=non-literal-null-conversion -Wno-invalid-offsetof -Wno-inline-new-delete -Wno-c
++0x-extensions -Wno-extended-offsetof -Wno-unknown-warning-option -Wno-return-type-c-linkage -Wno-error=uninitialized -Wno-error=deprecated-declarations -O2 -pipe -march=native -fstack-protector -march=native -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exception
s -fno-math-errno -std=gnu++0x -pthread -pipe -DNDEBUG -DTRIMMED -ggdb -Xclang -load -Xclang ../../build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fomit-frame-pointer -Werror /home/alex/gecko-dev/obj-x86_64-unknown-linux-gnu/layout/forms/
Unified_cpp_layout_forms0.cpp
11:11.14 /home/alex/gecko-dev/config/rules.mk:930: recipe for target 'Unified_cpp_layout_forms0.o' failed
11:11.14 gmake[5]: *** [Unified_cpp_layout_forms0.o] Error 1
11:11.14 /home/alex/gecko-dev/config/recurse.mk:74: recipe for target 'layout/forms/target' failed
11:11.14 gmake[4]: *** [layout/forms/target] Error 2


Expected results:

Successful build.

Comment 1

[Alex Xu]

Probably a variation of this bug.

Comment 2

[Kanchan Kumari QA]

Hello Alex, Thanks for reporting this issue. Is this still an issue for you? Can you please confirm and change the  status accordingly? We are in the process of cleaning up untriaged bugs. For now I am changing the component to general. Thanks.