Closed Bug 1125693 Opened 6 years ago Closed 6 years ago

Fix -Wformat warning in xpcom/base/nsStackWalk.cpp and mark as FAIL_ON_WARNINGS

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

clang warns that aLOffset is ptrdiff_t (signed int), but the format string specifier is PRIxPTR, which assumes unsigned uintptr_t:

xpcom/base/nsStackWalk.cpp:1138:48: warning: format specifies type 'unsigned long' but the argument has type 'ptrdiff_t' (aka 'int') [-Wformat]

This is the last warning in the xpcom/base directory, so we can mark it as FAIL_ON_WARNINGS for all platforms.
Attachment #8554344 - Flags: review?(continuation)
Attachment #8554344 - Flags: review?(continuation) → review?(n.nethercote)
Attachment #8554344 - Flags: review?(n.nethercote) → review+
https://hg.mozilla.org/mozilla-central/rev/23943d3f9c0e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Depends on: 1126985
You need to log in before you can comment on or make changes to this bug.