1125698 - js/src/jscntxt.cpp:862:74: warning: variable 'dummy' is uninitialized when used here [-Wuninitialized]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Chris Peterson [:cpeterson]]

clang warns that js_ReportErrorNumberUCArray() passes va_list dummy to js_ExpandErrorArguments() without having initialized dummy with va_start. However, js_ReportErrorNumberUCArray() is not a variadic function, so it can't call va_start() itself without clang emitting a -Wvarargs warning.

js/src/jscntxt.cpp:862:74: warning: variable 'dummy' is uninitialized when used here [-Wuninitialized]

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: ExpandErrorArgumentsVA.patch

1. Add ExpandErrorArguments() varargs helper function and remove uninitialized `dummy` va_list variable.

2. Rename original ExpandErrorArguments() function to ExpandErrorArgumentsVA() like other SpiderMonkey functions that take a va_list parameter (and to differentiate it from the new helper function).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=97a6af09b2a6

Comment 2

[Chris Peterson [:cpeterson]]

Thanks. I believe this was the last -Wuninitialized from clang and gcc in mozilla-central.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5782f959c94

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f5782f959c94