Closed
Bug 1125764
Opened 9 years ago
Closed 9 years ago
Page can no longer hide UITour annotations and menus on page refresh or navigating to a new page
Categories
(Firefox :: Tours, defect)
Tracking
()
People
(Reporter: agibson, Assigned: MattN)
References
Details
Attachments
(1 file, 1 obsolete file)
Since Bug 1110602 landed, it look like UITour highlights & info panels are no longer being hidden when refreshing the web page. STR: 1.) In the latest Nightly, click Help -> Nihghtly Tour 2.) When the doorhanger shows to start the tour, click "Let's go" 3.) The first step of the tour now opens the menu panel 4.) Hit refresh to reload the page Expected results: The menu panel and highlight should have been hidden. Actual results: The menu panel remains open when the page reloads I think we should be able to work around this on the web side by making sure we send "hide" events on the `beforeunload` event
Reporter | ||
Comment 1•9 years ago
|
||
I notice the same also happens if you click a link and navigate to another page when a highlight is showing. I'm guessing this is because Bug 1123010 hasn't been implemented. Matt - is this something that is going to be picked up shortly and something I shouldn't have to worry about on the web side?
Flags: needinfo?(MattN+bmo)
Reporter | ||
Updated•9 years ago
|
Summary: UITour Highlights and panels are no longer hidden on page refresh → UITour Highlights and panels are no longer hidden on page refresh or navigating to a new page
Assignee | ||
Comment 2•9 years ago
|
||
Note that I don't think the summary is a Firefox regression as bug 1123010 behavior never worked but bug 1079554 made the page's own cleanup via hide* methods ignored. If we don't fix bug 1123010, the short-term fix is adding the hide methods to BACKGROUND_PAGE_ACTIONS_ALLOWED.
Blocks: CVE-2015-0819
Flags: needinfo?(MattN+bmo)
Reporter | ||
Comment 3•9 years ago
|
||
(In reply to Matthew N. [:MattN] from comment #2) > If we don't fix bug 1123010, the short-term fix is adding > the hide methods to BACKGROUND_PAGE_ACTIONS_ALLOWED. Given that this is currently causing some odd quirks in production for Firefox 36+, can we get one of these fixes in soon?
Assignee | ||
Comment 4•9 years ago
|
||
I'll do the short-term fix now.
Assignee: nobody → MattN+bmo
Blocks: fx-UITour-hello-36
Status: NEW → ASSIGNED
Iteration: --- → 38.1 - 26 Jan
Points: --- → 2
status-firefox36:
--- → affected
status-firefox37:
--- → affected
status-firefox38:
--- → affected
Flags: qe-verify-
Flags: firefox-backlog+
Hardware: x86 → All
Version: 37 Branch → 36 Branch
Assignee | ||
Updated•9 years ago
|
Summary: UITour Highlights and panels are no longer hidden on page refresh or navigating to a new page → Page can no longer hide UITour annotations and menus on page refresh or navigating to a new page
Assignee | ||
Comment 5•9 years ago
|
||
/r/2997 - Bug 1125764 - Allow tour pages to hide UITour annotations and menus when losing visibility. r=dolske Pull down this commit: hg pull review -r bb18926ea566929f685a462eb88552a91b63f8cd
Attachment #8554784 -
Flags: review?(dolske)
Reporter | ||
Comment 6•9 years ago
|
||
Many thanks for submitting the quick fix, Matt!
Updated•9 years ago
|
Iteration: 38.1 - 26 Jan → 38.2 - 9 Feb
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8554784 [details] MozReview Request: bz://1125764/MattN /r/2997 - Bug 1125764 - Allow tour pages to hide UITour annotations and menus when losing visibility. r=dolske Pull down this commit: hg pull review -r bb18926ea566929f685a462eb88552a91b63f8cd
Attachment #8554784 -
Flags: review?(bmcbride)
Comment 8•9 years ago
|
||
https://reviewboard.mozilla.org/r/2997/#review2461 Ship It! ::: browser/components/uitour/UITour.jsm (Diff revision 1) > + "hideMenu", endUrlbarCapture should probably be here too (until we decide to jetison it).
Comment 9•9 years ago
|
||
Comment on attachment 8554784 [details] MozReview Request: bz://1125764/MattN https://reviewboard.mozilla.org/r/2995/#review2463 Ship It!
Attachment #8554784 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 10•9 years ago
|
||
(In reply to Blair McBride [:Unfocused] from comment #8) > endUrlbarCapture should probably be here too (until we decide to jetison it). Yeah, I think we can remove it any day now… https://hg.mozilla.org/integration/fx-team/rev/42750f461e95
Whiteboard: [fixed-in-fx-team]
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/42750f461e95
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Updated•9 years ago
|
Attachment #8554784 -
Flags: review?(dolske)
Reporter | ||
Comment 12•9 years ago
|
||
This is fixed in Nightly, but still effects Firefox 36 & 37. Does this need uplifting still, given that Bug 1110602 got uplifted?
Assignee | ||
Comment 13•9 years ago
|
||
Yes, I'm requesting all of the UITour uplifts today.
Assignee | ||
Comment 14•9 years ago
|
||
Note that status-firefox36: affected & status-firefox37: affected state that uplift is needed.
Assignee | ||
Comment 15•9 years ago
|
||
Comment on attachment 8554784 [details] MozReview Request: bz://1125764/MattN Approval Request Comment [Feature/regressing bug #]: Bug 1079554 & Bug 1118874 - Hello tour/snippet/product page for 36 [User impact if declined]: Tour annotations aren't torn down in some cases. [Describe test coverage new/current, TreeHerder]: This returns to behaviour from before 1079554 for a few APIs [Risks and why]: Low risk isolated to UITour. Returning to older behaviour as a stop-gap for the proper solution. [String/UUID change made/needed]: None RyanVM/others: Note that I will do uplifts myself since there are many UITour patches to uplift in the correct order.
Attachment #8554784 -
Flags: approval-mozilla-beta?
Attachment #8554784 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8554784 -
Flags: approval-mozilla-beta?
Attachment #8554784 -
Flags: approval-mozilla-beta+
Attachment #8554784 -
Flags: approval-mozilla-aurora?
Attachment #8554784 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 17•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/756c22d18cdf
Assignee | ||
Comment 18•9 years ago
|
||
Attachment #8554784 -
Attachment is obsolete: true
Attachment #8619221 -
Flags: review+
Assignee | ||
Comment 19•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•