1125921 - add win64 mozconfigs

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[[e-mail] (:bhearsum)]

We need release (en-US + l10n) ones in the gecko repo at the very least. We probably need en-US ones in buildbot-configs to make release sanity happy too.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: adjust in-tree mozconfigs

The big thing here is the addition of the l10n mozconfig. The small thing here is the cleanup of vs2013 mozconfig stuff (basically, putting it all in common-opt for both win32 and win64).

l10n release mozconfigs are in buildbot. I have another patch for that.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: add l10n mozconfig

I'm not 100% certain than these will pass release sanity, but it'll be easier to deal with failures like that later...

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 8554685 [details] [diff] [review]
add l10n mozconfig

I'm pretty sure you don't need this, see http://hg.mozilla.org/build/tools/file/beae324192d5/scripts/l10n/create-release-repacks.py#l278

Let's try without this patch first at least.

Comment 4

[[e-mail] (:bhearsum)]

OK, the latest nightlies are failing with:
#define CONFIGURE_STATIC_ASSERT(condition) CONFIGURE_STATIC_ASSERT_IMPL(condition, __LINE__)
#define CONFIGURE_STATIC_ASSERT_IMPL(condition, line) CONFIGURE_STATIC_ASSERT_IMPL2(condition, line)
#define CONFIGURE_STATIC_ASSERT_IMPL2(condition, line) typedef int static_assert_line_##line[(condition) ? 1 : -1]

int main() {
CONFIGURE_STATIC_ASSERT(0)
; return 0; }
configure:8254: checking for 64-bit OS
configure:8263: cl -c  -TC -nologo -D_HAS_EXCEPTIONS=0  conftest.c 1>&5
conftest.c
configure: error: You are targeting i386 but using the 64-bit compiler.
*** Fix above errors and then restart with\
               "c:/builds/moz2_slave/m-cen-w64-l10n-ntly-0000000000/build/mozilla-central/mozmake.exe -f client.mk build"
client.mk:361: recipe for target 'configure' failed
configure: error: You are targeting i386 but using the 64-bit compiler.

Progress!

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum [:bhearsum] from comment #4)
> OK, the latest nightlies are failing with:
> #define CONFIGURE_STATIC_ASSERT(condition)
> CONFIGURE_STATIC_ASSERT_IMPL(condition, __LINE__)
> #define CONFIGURE_STATIC_ASSERT_IMPL(condition, line)
> CONFIGURE_STATIC_ASSERT_IMPL2(condition, line)
> #define CONFIGURE_STATIC_ASSERT_IMPL2(condition, line) typedef int
> static_assert_line_##line[(condition) ? 1 : -1]
> 
> int main() {
> CONFIGURE_STATIC_ASSERT(0)
> ; return 0; }
> configure:8254: checking for 64-bit OS
> configure:8263: cl -c  -TC -nologo -D_HAS_EXCEPTIONS=0  conftest.c 1>&5
> conftest.c
> configure: error: You are targeting i386 but using the 64-bit compiler.
> *** Fix above errors and then restart with\
>               
> "c:/builds/moz2_slave/m-cen-w64-l10n-ntly-0000000000/build/mozilla-central/
> mozmake.exe -f client.mk build"
> client.mk:361: recipe for target 'configure' failed
> configure: error: You are targeting i386 but using the 64-bit compiler.
> 
> Progress!

Looks like this is because we don't have the proper target (and possibly host set). Here's an excerpt from the 64-bit build log:
  --target=x86_64-pc-mingw32
  --host=x86_64-pc-mingw32
checking host system type... x86_64-pc-mingw32
checking target system type... x86_64-pc-mingw32
checking build system type... x86_64-pc-mingw32

And here's what l10n has:
checking host system type... i686-pc-mingw32
checking target system type... i686-pc-mingw32
checking build system type... i686-pc-mingw32

Comment 6

[[e-mail] (:bhearsum)]

Attachment: include thing with target/host definitions

Missed this extra include. This file has these in it:

ac_add_options --target=x86_64-pc-mingw32
ac_add_options --host=x86_64-pc-mingw32

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 8555365 [details] [diff] [review]
include thing with target/host definitions

https://hg.mozilla.org/mozilla-central/rev/08e41ea36f6d

Comment 8

[[e-mail] (:bhearsum)]

More bustage:
c:\mozilla-build\python27\python2.7.exe: can't open file 'c:/builds/moz2_slave/try-w64-0000000000000000000000/build/sccache/sccache.py': [Errno 2] No such file or directory
configure: failed program was:
#line 4179 "configure"
#include "confdefs.h"
#include <stdio.h>
int main() {
 printf("Hello World\n"); 
; return 0; }
configure: error: $(CC) test failed.  You must have MS VC++ in your path to build.
*** Fix above errors and then restart with\
               "c:/builds/moz2_slave/try-w64-0000000000000000000000/build/mozmake.exe -f client.mk build"
c:/builds/moz2_slave/try-w64-0000000000000000000000/build/client.mk:361: recipe for target 'configure' failed
mozmake.exe[2]: *** [configure] Error 1
mozmake.exe[2]: Leaving directory 'c:/builds/moz2_slave/try-w64-0000000000000000000000/build'
c:/builds/moz2_slave/try-w64-0000000000000000000000/build/client.mk:375: recipe for target 'c:/builds/moz2_slave/try-w64-0000000000000000000000/build/obj-firefox/Makefile' failed
mozmake.exe[1]: Leaving directory 'c:/builds/moz2_slave/try-w64-0000000000000000000000/build'
mozmake.exe[1]: *** [c:/builds/moz2_slave/try-w64-0000000000000000000000/build/obj-firefox/Makefile] Error 2
client.mk:171: recipe for target 'build' failed

Seems to be happening on all try pushes that include win64.

Comment 9

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum [:bhearsum] from comment #8)
> More bustage:
> c:\mozilla-build\python27\python2.7.exe: can't open file
> 'c:/builds/moz2_slave/try-w64-0000000000000000000000/build/sccache/sccache.
> py': [Errno 2] No such file or directory

It looks like sccache is grabbed from tooltool. Perhaps that step isn't running for 64-bit builds....

Comment 10

[[e-mail] (:bhearsum)]

Yup, compare http://mxr.mozilla.org/mozilla-central/source/browser/config/tooltool-manifests/win32/releng.manifest to http://mxr.mozilla.org/mozilla-central/source/browser/config/tooltool-manifests/win64/releng.manifest.

Comment 11

[[e-mail] (:bhearsum)]

Attachment: fix win64 sccache

I think this will fix the pushes to try. I don't know why non-try builds work, tbh. Maybe there's some buildbot-configs differences too...

Comment 12

[Mike Hommey [:glandium]]

(In reply to Ben Hearsum [:bhearsum] from comment #11)
> Created attachment 8555489 [details] [diff] [review]
> fix win64 sccache
> 
> I think this will fix the pushes to try. I don't know why non-try builds
> work, tbh. Maybe there's some buildbot-configs differences too...

sccache is not enabled on windows builds on non-try.

Comment 13

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=try&job_id=4523902
repository: try
start_time: 2015-01-28T05:42:53
who: VYV03354[at]nifty[dot]ne[dot]jp
machine: b-2008-ix-0025
buildname: WINNT 6.1 x86-64 try leak test build
revision: 2d64e4339027

mozmake.exe[2]: *** [configure] Error 1
mozmake.exe[1]: *** [c:/builds/moz2_slave/try-w64-d-00000000000000000000/build/obj-firefox/Makefile] Error 2
mozmake.exe: *** [build] Error 2

Comment 14

[[e-mail] (:bhearsum)]

Attachment: roll up patch for aurora

This is a roll-up patch of all of the mozconfig+tooltool config changes that were needed so far for mozilla-central. There may be additional patches needed (it's not clear yet), but there's no reason not to land this in the meantime. All of this code has been previously reviewed, so not setting r?.

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8555956 [details] [diff] [review]
roll up patch for aurora

Aurora+

Comment 16

[[e-mail] (:bhearsum)]

Comment on attachment 8555956 [details] [diff] [review]
roll up patch for aurora

Landed this on aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/0244a7d16f88

Comment 17

[[e-mail] (:bhearsum)]

I think we're all done here now. If there's any follow-up work required we'll track it in a new bug.