Last Comment Bug 1125971 - Fixing quotes on /fr/privacy/tips/ and removing extra space before the closing quotation mark
: Fixing quotes on /fr/privacy/tips/ and removing extra space before the closin...
Status: RESOLVED FIXED
[kb=1645506]
:
Product: www.mozilla.org
Classification: Other
Component: Bedrock (show other bugs)
: Production
: x86_64 Linux
-- normal
: ---
Assigned To: Théo Chevalier [:tchevalier]
:
:
Mentors:
Depends on:
Blocks: 1109318
  Show dependency treegraph
 
Reported: 2015-01-26 12:42 PST by Théo Chevalier [:tchevalier]
Modified: 2015-01-30 08:18 PST (History)
6 users (show)
See Also:
Locale:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Link to Github pull-request: https://github.com/mozilla/bedrock/pull/2681 (44 bytes, text/x-github-pull-request)
2015-01-26 12:54 PST, Théo Chevalier [:tchevalier]
no flags Details | Review | Splinter Review

Description User image Théo Chevalier [:tchevalier] 2015-01-26 12:42:19 PST
https://www.mozilla.org/fr/privacy/tips/ is currently using English typography for the quotes.

Pascal made me notice that we could easily fix that for French.
I also removed the extra space before the closing quotation mark, due to <p> tag being on a new line (that's affecting all locales).
Comment 1 User image Théo Chevalier [:tchevalier] 2015-01-26 12:54:07 PST
Created attachment 8554736 [details] [review]
Link to Github pull-request: https://github.com/mozilla/bedrock/pull/2681
Comment 2 User image [github robot] 2015-01-30 03:27:36 PST
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/d71cc7583f246f1f54279e2395e854ce69142a1c
Bug 1125971 - Fixing quotes on /fr/privacy/tips/ and removing extra space before the closing quotation mark

https://github.com/mozilla/bedrock/commit/0f668e944e91efd02d6bf646f74b22420116bb3d
Merge pull request #2681 from TheoChevalier/privacy-day-tips-fix-french

Bug 1125971 - Fixing quotes on /fr/privacy/tips/ and removing extra spac...

Note You need to log in before you can comment on or make changes to this bug.