Closed
Bug 1126017
Opened 8 years ago
Closed 8 years ago
Use --enable-warnings-as-errors on Win64 builders
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla38
People
(Reporter: emk, Assigned: emk)
References
Details
Attachments
(1 file)
1.47 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Before another Win64-specific warning sneaks in.
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=745ff4832e37
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8554797 [details] [diff] [review] use_warnings_as_errors_on_win64 Green on try.
Attachment #8554797 -
Flags: review?(mh+mozilla)
Updated•8 years ago
|
Attachment #8554797 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3c8794b37bf
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Flags: in-testsuite-
Comment 4•8 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #2) > Comment on attachment 8554797 [details] [diff] [review] > use_warnings_as_errors_on_win64 > > Green on try. indeed but had to back this out for bustage sorry. Bustage log like https://treeherder.mozilla.org/logviewer.html#?job_id=5965743&repo=mozilla-inbound
Flags: needinfo?(VYV03354)
Comment 5•8 years ago
|
||
Unfortunately we failed to land this before the "next" warning landed... I've marked bug 1124029 leave-open, and will fix any new warnings tomorrow. I guess I probably should land this patch at the same time when I land the fixes, so that we won't let others to introduce new breakage :)
Comment 8•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c5a675350518
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Updated•5 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•