Closed Bug 1126017 Opened 5 years ago Closed 5 years ago

Use --enable-warnings-as-errors on Win64 builders

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
Windows 8.1
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla38

People

(Reporter: emk, Assigned: emk)

References

Details

Attachments

(1 file)

use_warnings_as_errors_on_win64
1.47 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
Before another Win64-specific warning sneaks in.
Comment on attachment 8554797 [details] [diff] [review]
use_warnings_as_errors_on_win64

Green on try.
Attachment #8554797 - Flags: review?(mh+mozilla)
Attachment #8554797 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3c8794b37bf
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Flags: in-testsuite-
(In reply to Masatoshi Kimura [:emk] from comment #2)
> Comment on attachment 8554797 [details] [diff] [review]
> use_warnings_as_errors_on_win64
> 
> Green on try.

indeed but had to back this out for bustage sorry. Bustage log like https://treeherder.mozilla.org/logviewer.html#?job_id=5965743&repo=mozilla-inbound
Flags: needinfo?(VYV03354)
Unfortunately we failed to land this before the "next" warning landed... I've marked bug 1124029 leave-open, and will fix any new warnings tomorrow.

I guess I probably should land this patch at the same time when I land the fixes, so that we won't let others to introduce new breakage :)
Yeah, I've lost the race :(
Flags: needinfo?(VYV03354)
https://hg.mozilla.org/mozilla-central/rev/c5a675350518
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.