1126017 - Use --enable-warnings-as-errors on Win64 builders

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Masatoshi Kimura [:emk]]

Before another Win64-specific warning sneaks in.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: use_warnings_as_errors_on_win64

https://treeherder.mozilla.org/#/jobs?repo=try&revision=745ff4832e37

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8554797 [details] [diff] [review]
use_warnings_as_errors_on_win64

Green on try.

Comment 3

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c3c8794b37bf

Comment 4

[Carsten Book [:Tomcat]]

(In reply to Masatoshi Kimura [:emk] from comment #2)
> Comment on attachment 8554797 [details] [diff] [review]
> use_warnings_as_errors_on_win64
> 
> Green on try.

indeed but had to back this out for bustage sorry. Bustage log like https://treeherder.mozilla.org/logviewer.html#?job_id=5965743&repo=mozilla-inbound

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Unfortunately we failed to land this before the "next" warning landed... I've marked bug 1124029 leave-open, and will fix any new warnings tomorrow.

I guess I probably should land this patch at the same time when I land the fixes, so that we won't let others to introduce new breakage :)

Comment 6

[Masatoshi Kimura [:emk]]

Yeah, I've lost the race :(

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5a675350518

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c5a675350518