1126035 - Make android emulator command line more configurable

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

We "hard code" much of the command line used to start the emulator for android emulator unit tests:

http://hg.mozilla.org/build/mozharness/annotate/fae840c24e70/scripts/android_emulator_unittest.py#l213

Some of those options are not required for Android 4.4.

We could make this more flexible using another parameter or two in the mozharness configuration.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: move emulator command line info into mozharness configuration

This simplifies android_emulator_unittest.py and moves that logic into the configuration files, which will make it easy for me to customize for the Android 4.4 work that I am doing, if necessary.

I used https://treeherder.mozilla.org/#/jobs?repo=try&revision=9320daf495d7 to verify that the existing emulator command lines remain the same (except for some harmless argument re-ordering) and tests continue to run.

New Android 2.3:
18:36:40     INFO - Trying to start the emulator with this command: emulator -avd test-1 -port 5554 -debug init,console,gles,memcheck,adbserver,adbclient,adb,avd_config,socket -qemu -m 1024 -cpu cortex-a9

New Android x86:
15:48:23     INFO - Trying to start the emulator with this command: emulator -avd test-1 -port 5554 -debug init,console,gles,memcheck,adbserver,adbclient,adb,avd_config,socket -qemu -m 1024 -enable-kvm

Comment 2

[Armen [:armenzg]]

Comment on attachment 8555038 [details] [diff] [review]
move emulator command line info into mozharness configuration

Beautiful! You bring joy to my heart! :)

This will make it easier in the future if we want to manipulate the values from the tree.

Comment 3

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/build/mozharness/rev/11f1def43e6d

Comment 4

[Jordan Lund (:jlund)]

In production: https://hg.mozilla.org/build/mozharness/rev/11f1def43e6d