Differential Testing: Different output message involving Math.max

RESOLVED FIXED

Status

()

Core
JavaScript Engine: JIT
--
major
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gkw, Unassigned)

Tracking

(Blocks: 2 bugs, {regression, testcase})

Trunk
x86_64
Mac OS X
regression, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38 affected)

Details

(Reporter)

Description

3 years ago
function f(x) {
    0 < (Math.max(x >>> 0, (2147483649 !== 0) >> 0) | 0) ? undefined() : x;
};
try {
    f(4294967296);
    f(4294967296);
} catch (e) {}
try {
    print(f(2147483649));
    f(4294967296);
} catch (e) {}


$ ./js-dbg-opt-32-dm-nsprBuild-armSim-darwin-95c76c3b0172 --fuzzing-safe --no-threads --ion-eager testcase.js

$ ./js-dbg-opt-32-dm-nsprBuild-armSim-darwin-95c76c3b0172 --fuzzing-safe --no-threads --ion-eager --ion-check-range-analysis --no-sse3 testcase.js
undefined

Tested this on m-c rev 95c76c3b0172.

My configure flags are:

LD=ld CROSS_COMPILE=1 CC="clang -Qunused-arguments -msse2 -mfpmath=sse -arch i386" RANLIB=ranlib CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse -arch i386" AS=$CC AR=ar STRIP="strip -x -S" HOST_CC="clang -Qunused-arguments -msse2 -mfpmath=sse" AUTOCONF=/usr/local/Cellar/autoconf213/2.13/bin/autoconf213 HOST_CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse" sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=i386-apple-darwin9.2.0 --enable-macos-target=10.5 --enable-arm-simulator --enable-debug --enable-optimize --enable-nspr-build --enable-more-deterministic --with-ccache --enable-gczeal --enable-debug-symbols --disable-tests

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/1b13ea9bf489
user:        Hannes Verschore
date:        Wed Sep 10 23:21:12 2014 +0200
summary:     Bug 1064251 - IonMonkey: Fold strict (not) equal on constant numbers, r=sstangl

Hannes, is bug 1064251 a likely regressor?
Flags: needinfo?(hv1989)
(Reporter)

Comment 1

3 years ago
I suspect this may be bug 1124448 or bug 1122402.
(In reply to Gary Kwong [:gkw] [:nth10sd] from comment #1)
> I suspect this may be bug 1124448 or bug 1122402.

I suspect too. I'll take a look later in the week. (Hoping bug 1122402 has progressed and fixes this too).
(Reporter)

Comment 3

3 years ago
I think this is fixed, and likely by bug 1122402.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(hv1989)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.