1126082 - [SIM Pin] If Airplane Mode is on, the "OK" button on the SIM pin screen does not do anything

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: SIM PIN Airplane Logcat.txt

Description:
If airplane mode is on while the SIM pin screen is active, the "ok" button does nothing

Prerequisites: Have a SIM card with a SIM pin in the device

Repro Steps:
1) Update a Flame to 20150126010231
2) Unlock the device
3) When prompted to put in a SIM pin, pull down the notification bar and enable airplane mode
4) Enter in the SIM pin and tap "OK"

Actual:
The "OK" button doesnt do anything

Expected:
The "OK" button dismisses the SIM pin prompt, or gives the user an error message informing them that airplane mode is enabled

Environmental Variables:
Device: Flame 3.0 (319Mb)(Kitkat)(Full Flash)
BuildID: 20150126010231
Gaia: 0f662dffef27599443cfcd790c2b39190a2b35c8
Gecko: fa91879c8428
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 15/15 100%
See attached: Logcat, Video - http://youtu.be/H8Tb-vV0WEs

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue happens on all branches of Flame with the v18D-1 base, and happens on the v18D base, as well as v188-1 Base

The "OK" button doesnt do anything

Environmental Variables:
Device: Flame Base v18D-1 (319Mb)(Kitkat)
Build ID: 20150106124450
Gaia: 79f6218c4f30c2739575c3ab800078c2cda135cb
Gecko: d9d4000dd43a3637345a41d716dc97fdd700d715
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Environmental Variables:
Device: Flame Base v18D (319Mb)(Kitkat)
Build ID: 20141215191148
Gaia: 79f6218c4f30c2739575c3ab800078c2cda135cb
Gecko: d9d4000dd43a3637345a41d716dc97fdd700d715
Version: 32.0 (2.0)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Environmental Variables:
Device: Flame Base v188-1
Build ID: 20141021162107
Gaia: 8c5c956ee6909408e29f375cc7d843a03d92f3d8
Gecko: 60bf345874982e25236ffb80f41e33fdb8ac94f9
Version: 32.0 (2.0)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Peter Bylenga [:PBylenga]]

NI on component owner for nomination decision as well as assignment.  Not a regression.

Comment 3

[Gerry Chang [:gchang]]

This might need developer's help for more information.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

It seems the case has not been handled. Alberto, any ideas?

Comment 5

[Alberto Pastor [:albertopq]]

I think we probably should dismiss the PIN dialog when entering in Flight mode. Asking Ux input here.

Comment 6

[Rob MacDonald [:robmac]]

I agree. If the user turns on flight mode manually, then the dialog should be dismissed on its own. When the user turns off flight mode, they would then be re-prompted. NI'ing Carrie from Comms UX to confirm.

Comment 7

[Carrie Wang [New account: [e-mail]]]

Agree on comment 6. Thanks!

Comment 8

[Hermes Cheng (inactive after July 27, 2015)]

It seems the conclusion is to dismiss the PIN dialog when Flight mode.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

I think so. Redirect to the owner.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1126082-sim-airplane-dismiss > mozilla-b2g:master

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8567882 [details] [review]
[gaia] albertopq:1126082-sim-airplane-dismiss > mozilla-b2g:master

Looks good. Thanks alberto

Comment 12

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/a7fd4093df2fd93b47d0393ae5cf1ace60c7d1f7

Comment 13

[Alberto Pastor [:albertopq]]

Blocking a blocker

Comment 14

[Hermes Cheng (inactive after July 27, 2015)]

Alberto, could you please uplift to v2.2? Thanks.

Comment 15

[Alberto Pastor [:albertopq]]

Comment on attachment 8567882 [details] [review]
[gaia] albertopq:1126082-sim-airplane-dismiss > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: The OK button in the PIN dialog does nothing when entering in airplane mode
[Testing completed]: Added unit tests
[Risk to taking this patch] (and alternatives if risky): Only dismissing the dialog when an event is received. Not very risky
[String changes made]: -

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8567882 [details] [review]
[gaia] albertopq:1126082-sim-airplane-dismiss > mozilla-b2g:master

[e-mail] should be used for Firefox Desktop and Mobile.

Comment 17

[Alberto Pastor [:albertopq]]

Sorry, just did it because :fabrice redirected the approval to that account yesterday with bug 1132397

'Attachment #8568440 [details] - Flags: approval-gaia-v2.2?([e-mail]) → approval-gaia-v2.2?([e-mail])'

Good to know! Thanks!

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/1fdcccf9de5b54fde160e2d07903dc5cec8f76e2

Comment 19

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed for the latest Nightly 3.0 and 2.2 builds.

Actual Results: The prompt for SIM pin is dismissed when Airplane mode is turned on.
	
Environmental Variables:
Device: Flame 3.0 KK (Full Flash) (319 MB)
BuildID: 20150303010233
Gaia: c8ed1085a67490a1ecd7f275e5de9487e1b93b1d
Gecko: 0b3c520002ad
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Environmental Variables:
Device: Flame 2.2 KK (Full Flash) (319 MB)
BuildID: 20150303002527
Gaia: 3d188c414e30acc392253d5389a42352fcfbc183
Gecko: c89aad487aa5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 20

[Shine(Leave from Mozilla)]

Per comment 19, clear the verifyme tag.