1126094 - GTK3 does not report correct screen size with HiDPI displays

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Andrew Comminos [:acomminos]]

Half of the available screen size is reported, caused by an incomplete upscale when nsScreenGtk is initialized from a GdkWindow (mRect and mAvailRect are in display pixels, but initialized with GDK coords). This causes issues with dialog positioning, such as the top-right menu appearing in the center of the screen.

For example; I have a 2560x1600 HiDPI display with a scaling factor of 2. 1280x800 in GDK coords are available, but sites such as http://whatsmy.browsersize.com/ report only 640x400.

This is caused by changes made in bug #975919.

Comment 1

[Andrew Comminos [:acomminos]]

Attachment: Use proper units for nsScreenGtk initialization with a HiDPI display

Karl, this is a revised version of the nsScreenGtk changes factored out of bug 975919. This should set the proper screen size in pixels for both Xinerama and GdkWindow nsScreenGtk initialization.

Thanks!

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Try build: https://tbpl.mozilla.org/?tree=Try&rev=a57d8324823f

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Let's check this in, try looks okay.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00137d5cdc70

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/00137d5cdc70