1126171 - Line feeds in string used to generate Hello invitation emails is not parsed correctly by tools

Status: RESOLVED WORKSFORME

(Hello (Loop) :: Client, defect)

Description

[Francesco Lodolo [:flod]]

As noted in bug 1113090, the "\r\n" combination generates issues with external localization tools. From a localizer point of view, it also makes the string quite unreadable.

Original string: http://hg.mozilla.org/releases/mozilla-aurora/file/default/browser/locales/en-US/chrome/browser/loop/loop.properties#l68

share_email_body4=Hello!\r\n\r\nJoin me for a video conversation using {{clientShortname}}:\r\n\r\nYou don't have to download or install anything. Just copy and paste this URL into your browser:\r\n\r\n{{callUrl}}\r\n\r\nIf you want, you can also learn more about {{clientShortname}} at {{learnMoreUrl}}\r\n\r\nTalk to you soon!

This is the exported results (\r is lost)
http://hg.mozilla.org/releases/l10n/mozilla-aurora/cy/file/d31dcb9f223d/browser/chrome/browser/loop/loop.properties#l68

share_email_body4=Helo! \n\nYmunwch â mi mewn sgwrs fideo gan ddefnyddio {{clientShortname}}: \n\nDoes dim rhaid i chi lwytho i lawr na gosod dim. Dim ond copïo a gludo'r URL yma i'ch porwr: \n\n{{callUrl}} \n\nOs hoffech chi, mae modd dysgu rhagor am {{clientShortname}} yn {{learnMoreUrl}} \n\nEdrych ymlaen am sgwrs!

I'm not sure if we can split this string up, because localizers will loose control over the empty lines.

Comment 1

[Mark Banner (:standard8)]

Francesco, we're now using \n everywhere as a result of other bugs. Is there anything more we need here or can we close this bug?

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Mark Banner (:standard8) from comment #1)
> Francesco, we're now using \n everywhere as a result of other bugs. Is there
> anything more we need here or can we close this bug?

Yes, we can close this one. Not sure what's the proper resolution though (WORKSFORME given that's been fixed elsewhere?).

Comment 3

[Mark Banner (:standard8)]

Thanks, yeah lets go WFM.