1126175 - Test failure 'The correct SSL error title is shown - 'Unable to Connect Securely' should equal 'Secure Connection Failed ' in testSecurity/testSSLDisabledErrorPage.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Daniela Domnici]

Module:     testDisableSSL

Test:       /testSecurity/testSSLDisabledErrorPage.js

Errors:      The correct SSL error title is shown - 'Unable to Connect Securely' should equal 'Secure Connection Failed', The SSL error message contains disabled information - 'Firefox cannot guarantee the safety of your data on tlsv1-0.mozqa.com because it uses SSLv3, a broken security protocol.' should contain 'ssl_error_no_cypher_overlap'

Platforms:  All
 
Reports: http://mozmill-release.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2015-01-26&to=&test=%2FtestSecurity%2FtestSSLDisabledErrorPage.js&func=testDisableSSL

Comment 1

[Cosmin Malutan, [:cosmin-malutan]]

Since this failed for over 600 times on the last beta we might want to skip this, right?

Comment 2

[Daniela Domnici]

Attachment: skipSSLDisabledErrorPage

Created skip patch for beta branch.

Comment 3

[Andreea Matei [:AndreeaMatei]]

https://hg.mozilla.org/qa/mozmill-tests/rev/649f5d46a0dd (beta)

Comment 4

[Teodor Druta]

This looks like a regression on the latest beta I'll look over it.

Comment 5

[Teodor Druta]

Attachment: fixssldisable_beta.patch

This should fix the failures, also eventual future changes that's why I decided to use (oldSecurityProtTitle || nssFailure2title).

Comment 6

[Mihaela Velimiroviciu (:mihaelav)]

Comment on attachment 8555149 [details] [diff] [review]
fixssldisable_beta.patch

Review of attachment 8555149 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nit bellow fixed.

::: firefox/tests/remote/testSecurity/testSSLDisabledErrorPage.js
@@ +51,5 @@
>  
>    var nssFailure2title = utils.getEntity(DTDS, "nssFailure2.title");
> +  var oldSecurityProtTitle = utils.getEntity(DTDS, "oldSecurityProtocol.title");
> +  expect.waitFor(() => title.getNode().textContent ===
> +                 (oldSecurityProtTitle || nssFailure2title),

This should be aligned with title.getNode

Comment 7

[Teodor Druta]

Attachment: fixssldisable_beta.patch

Fixed.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Teodor Druta from comment #4)
> This looks like a regression on the latest beta I'll look over it.

What changeset caused this bustage on beta?

Comment 9

[Teodor Druta]

This is the changeset: https://hg.mozilla.org/releases/mozilla-beta/rev/ea3b10634381
Bug 1098371 - Create localized version of sslv3 error page

Comment 10

[Andreea Matei [:AndreeaMatei]]

https://hg.mozilla.org/qa/mozmill-tests/rev/b91de6dc453b (beta fix)
https://hg.mozilla.org/qa/mozmill-tests/rev/b01708546048 (beta unskip)

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Teodor Druta from comment #9)
> Bug 1098371 - Create localized version of sslv3 error page

Thanks. In the future please do not forget to update the dependencies and keywords.