If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Test failure 'The correct SSL error title is shown - 'Unable to Connect Securely' should equal 'Secure Connection Failed ' in testSecurity/testSSLDisabledErrorPage.js

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Daniela Domnici, Assigned: Teodor Druta)

Tracking

({regression})

Version 3
regression

Firefox Tracking Flags

(firefox36 fixed)

Details

(Whiteboard: [mozmill-test-failure], URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Module:     testDisableSSL

Test:       /testSecurity/testSSLDisabledErrorPage.js

Errors:      The correct SSL error title is shown - 'Unable to Connect Securely' should equal 'Secure Connection Failed', The SSL error message contains disabled information - 'Firefox cannot guarantee the safety of your data on tlsv1-0.mozqa.com because it uses SSLv3, a broken security protocol.' should contain 'ssl_error_no_cypher_overlap'

Platforms:  All
 
Reports: http://mozmill-release.blargon7.com/#/remote/failure?app=Firefox&branch=All&platform=All&from=2015-01-26&to=&test=%2FtestSecurity%2FtestSSLDisabledErrorPage.js&func=testDisableSSL
(Reporter)

Updated

3 years ago
status-firefox36: --- → affected
Whiteboard: [mozmill-test-failure]
Since this failed for over 600 times on the last beta we might want to skip this, right?
(Reporter)

Comment 2

3 years ago
Created attachment 8555078 [details] [diff] [review]
skipSSLDisabledErrorPage

Created skip patch for beta branch.
Attachment #8555078 - Flags: review?(hskupin)
Attachment #8555078 - Flags: review?(andreea.matei)
Attachment #8555078 - Flags: review?(hskupin)
Attachment #8555078 - Flags: review?(andreea.matei)
Attachment #8555078 - Flags: review+
https://hg.mozilla.org/qa/mozmill-tests/rev/649f5d46a0dd (beta)
status-firefox36: affected → disabled
Keywords: regression, regressionwindow-wanted
Whiteboard: [mozmill-test-failure] → [mozmill-test-failure][mozmill-test-skipped]
(Assignee)

Comment 4

3 years ago
This looks like a regression on the latest beta I'll look over it.
(Assignee)

Comment 5

3 years ago
Created attachment 8555149 [details] [diff] [review]
fixssldisable_beta.patch

This should fix the failures, also eventual future changes that's why I decided to use (oldSecurityProtTitle || nssFailure2title).
Assignee: nobody → teodor.druta
Status: NEW → ASSIGNED
Attachment #8555149 - Flags: review?(mihaela.velimiroviciu)
Attachment #8555149 - Flags: review?(andreea.matei)
Comment on attachment 8555149 [details] [diff] [review]
fixssldisable_beta.patch

Review of attachment 8555149 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nit bellow fixed.

::: firefox/tests/remote/testSecurity/testSSLDisabledErrorPage.js
@@ +51,5 @@
>  
>    var nssFailure2title = utils.getEntity(DTDS, "nssFailure2.title");
> +  var oldSecurityProtTitle = utils.getEntity(DTDS, "oldSecurityProtocol.title");
> +  expect.waitFor(() => title.getNode().textContent ===
> +                 (oldSecurityProtTitle || nssFailure2title),

This should be aligned with title.getNode
Attachment #8555149 - Flags: review?(mihaela.velimiroviciu) → review+
(Assignee)

Comment 7

3 years ago
Created attachment 8555156 [details] [diff] [review]
fixssldisable_beta.patch

Fixed.
Attachment #8555149 - Attachment is obsolete: true
Attachment #8555149 - Flags: review?(andreea.matei)
Attachment #8555156 - Flags: review?(andreea.matei)
(In reply to Teodor Druta from comment #4)
> This looks like a regression on the latest beta I'll look over it.

What changeset caused this bustage on beta?
(Assignee)

Comment 9

3 years ago
This is the changeset: https://hg.mozilla.org/releases/mozilla-beta/rev/ea3b10634381
Bug 1098371 - Create localized version of sslv3 error page
Attachment #8555156 - Flags: review?(andreea.matei) → review+
https://hg.mozilla.org/qa/mozmill-tests/rev/b91de6dc453b (beta fix)
https://hg.mozilla.org/qa/mozmill-tests/rev/b01708546048 (beta unskip)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox36: disabled → fixed
Resolution: --- → FIXED
(In reply to Teodor Druta from comment #9)
> Bug 1098371 - Create localized version of sslv3 error page

Thanks. In the future please do not forget to update the dependencies and keywords.
Blocks: 1098371
Keywords: regressionwindow-wanted
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [mozmill-test-failure][mozmill-test-skipped] → [mozmill-test-failure]
You need to log in before you can comment on or make changes to this bug.