1126177 - Test failure 'All pages have been visited' in /testAwesomeBar/testAccessLocationBar.js due to slow onVisit observer

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Daniela Domnici]

Module:   testAccessLocationBarHistory
Test:     /testAwesomeBar/testAccessLocationBar.js
Error:    All pages have been visited
Platform: Mac OS X

Failed 9 times with the new beta build.

Reports: http://mozmill-release.blargon7.com/#/functional/failure?app=Firefox&branch=All&platform=All&from=2015-01-26&to=&test=%2FtestAwesomeBar%2FtestAccessLocationBar.js&func=testAccessLocationBarHistory

Comment 1

[Teodor Druta]

This looks like an OSX non-en-US issue with the latest beta.

Comment 2

[Teodor Druta]

This is not reproducible locally. I wonder what went wrong on these nodes, the failures are really close to each other, timewise.

Comment 3

[Teodor Druta]

Still couldn't reproduce it locally using the same OS X version and beta build. What I actually think happens(ed) here is that the onVisit observer could be affected by the overall system performance, and from my personal experience OS X is really slow/bad performance and clumsy/unpredictable especially on a mini box, I suggest that we should increase the timeout for the waitFor here http://hg.mozilla.org/qa/mozmill-tests/file/2eddc7eace4b/lib/places.js#l185.
@Henrik, what do you think ?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Please see:
http://hg.mozilla.org/qa/mozmill-tests/file/2eddc7eace4b/lib/places.js#l20

I wonder why we haven't set it to 10s right away.

Comment 5

[Teodor Druta]

(In reply to Henrik Skupin (:whimboo) from comment #4)
> Please see:
> http://hg.mozilla.org/qa/mozmill-tests/file/2eddc7eace4b/lib/places.js#l20
> 
> I wonder why we haven't set it to 10s right away.

Ok, let's set this to 10s seconds as well then.

Comment 6

[Teodor Druta]

Attachment: b1126177.patch

This patch will increase the waitForVisited() waitFor() timeout to 10s.
It can be applied and was tested to all branches down to mozilla-esr31.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 07/21 - 08/08)]

Comment on attachment 8555203 [details] [diff] [review]
b1126177.patch

Review of attachment 8555203 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Lets get it landed!

Comment 8

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8555203 [details] [diff] [review]
b1126177.patch

Review of attachment 8555203 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/qa/mozmill-tests/rev/4083646df2d0 (default)

Comment 9

[Teodor Druta]

Comment on attachment 8555203 [details] [diff] [review]
b1126177.patch

Let's backport this all the way to esr31. The patch applies on all the branches, testruns all green.

Comment 10

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8555203 [details] [diff] [review]
b1126177.patch

Review of attachment 8555203 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/qa/mozmill-tests/rev/c30a3b844bc5 (aurora)
https://hg.mozilla.org/qa/mozmill-tests/rev/7e94e3829ff2 (beta)
https://hg.mozilla.org/qa/mozmill-tests/rev/b1a4fa227529 (release)
https://hg.mozilla.org/qa/mozmill-tests/rev/dc294c80d8d7 (esr31)