1126304 - [Loop] Counter isn't increased when user writes a space in Room's name

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Loli (:lolimartinezcr)]

Fire E 2.0
Loop 1.1.1/d4d6d37

Pre-requisites
User A logged in Mobile Loop application.

STR
- Taps on "New room" button.
- Write a subject:Room[space]with[space][space]-> ER1
- Write a subject:Room[space]with[space][space]f-> ER2

Actual result:
AR1: "91 characters left" is shows
AR2: "88 characters left" is shows
When user writes spaces between words, counter isn't increased.

Expected result:
ER1: "89 characters left" is shows.
ER2: "88 characters left" is shows.
Counter should be increased when user writes spaces.

Comment 1

[Cristian Rodriguez (:crdlc)]

In which document are you basing your expected behavior? The current implementation is based on a trim operation and AFAIK nobody from UX told me how to do this

Comment 2

[Maria Angeles Oteo (:oteo)]

(In reply to Cristian Rodriguez (:crdlc) from comment #1)
> In which document are you basing your expected behavior? The current
> implementation is based on a trim operation and AFAIK nobody from UX told me
> how to do this

Monica has confirmed the behavior today, anyway it's not a blocking bug so only if we have time to fix it and it's a no risky patch, we will consider to uplift it to 1.1.1 version

Comment 3

[Loli (:lolimartinezcr)]

(In reply to Cristian Rodriguez (:crdlc) from comment #1)
> In which document are you basing your expected behavior? The current
> implementation is based on a trim operation and AFAIK nobody from UX told me
> how to do this

I asked Monica (UX) and she said me it is correct behavior. Please, you should speak with she.

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Comment 5

[Cristian Rodriguez (:crdlc)]

master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/a5c8837a2e756681faa755d6c7efc6aba50d5f03

Comment 6

[Maria Angeles Oteo (:oteo)]

No riscky patch already verified by Loly and Monica, so giving the approval for the uplifting to 1.1.1 branch.
Cristian, please, uplift the patch when you have time

Thanks to all of you for the patch, the UX feedback and the testing!

Comment 7

[Cristian Rodriguez (:crdlc)]

in 1.1.1

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/be1f6493e77266fe30035e946867ccce910d4059

Comment 8

[Loli (:lolimartinezcr)]

Fire E 2.0
Loop 1.1.1/bd1a553

Counter isn't working in "call". 

STR
- Taps on "New call" button.
- Write a subject:call[space]with[space][space]-> ER1
- Write a subject:call[space]with[space][space]f-> ER2

Actual result:
AR1: "115 characters left" is shows
AR2: "112 characters left" is shows
When user writes spaces between words, counter isn't increased.

Expected result:
ER1: "113 characters left" is shows.
ER2: "112 characters left" is shows.
Counter should be increased when user writes spaces.

Also in a room,  the message "99 characters left"  is shown when user writes in textbox of subject while in a call the message "124 characters left" is shown directly. Call and rooms should have similar behavior in this case.

Comment 9

[Maria Angeles Oteo (:oteo)]

Cristian, can you have a look at it? It seems that we forgot to implement the same behavior in the subject of Loop call as you already did for Room's name.

Regarding when showing the the message "xx characters left" I think the correct behavior is the implemented in the Rooms, following the Wireframes in http://live.uxpin.com/a08e68faa1fb1267d18376af736f0ecdf204869a#/pages/15287297/sitemap.

We should only show the "xx characters left" when the user writes at least one character in the text box

Comment 10

[Maria Angeles Oteo (:oteo)]

I think it's better opening another bug to handle this issue

Comment 11

[Maria Angeles Oteo (:oteo)]

Already filed Bug 1129517, so closing this bug as Resolved as the issue in the name of the Room is fixed (changed also the title of the bug)

Comment 12

[Loli (:lolimartinezcr)]

Tested and now counter is increased when user inserts spaces in subject of room.
Fire E 2.0
Loop 1.1.1/39a5284