1126313 - [Loop] Device in silent mode manage notifications in a different way depending if owner is in the room or not

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[isabelrios]

Fire E 2.0
Loop 1.1.1/d4d6d7

User A has the device in silent mode.
User A creates and shares a room with user B

STR
Scenario 1:
User A is not in the room
User B joins in the room


Scenario 2:
User A is in the room, the app is set in background
User B joins in the room

EXPECTED
User A receives a notification with sound letting him know that user B joins in the room.
In both scenarios the behaviour should be the same

ACTUAL
Scenario 1: The notification is heard

Scenario 2: The notification is NOT heard

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

I should have a look a it to confirm but the fact is that when A joined the room the telephony audio channel is in use and the audio channel in use for the notification is notification which has lower priority than the telephony one. Need to confirm that this is what is going on but if so this is not a bug but how this is how supposed to work.

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Well, I'll try to explain what's is going on here. Notifications don't play any sound at all if the device is in silent mode. In scenario 1, what Isabel heard is the tone the app play when someone joins a room the logged user owns. That tone is heard because is played on the normal channel. Isabel was not silencing that channel. In scenario 2, the notification we send when the app goes into background doesn't play any sound for two reason, i) the device is in silent mode and ii) because the reason explained in comment 1.

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Well, after an offline chat the plan is to play the someone-joined-a-room-you-own tone in the notification audio channel. That way we will have the same behavior. Patch coming.

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/firefoxos-loop-client/pull/521

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Landed on master branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/82b8f4ff724a87ffa38a163c08486c4c95e17e8f

Comment 6

[Maria Angeles Oteo (:oteo)]

After some testing I think the issue is fixed. Setting Ringer and Notification Volume in the Room creator device to 0 (No sound), the notification when a invited user joins to that Room is not heard anymore in the scenarios described in the STR of the bug.

Isabel, it'd be great if you can do some testing to confirm all is fine. 

In the meantime, I am setting the approval whiteboard so JA can do the uplifting to 1.1.1 branch. 

Thanks a lot to all of you!

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Landed on 1.1.1 branch at:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/5c035876f5a762139adf3de25f83b7771908d687.

Comment 8

[isabelrios]

Sure, I will test the patch and give feedback as soon as I can
Thanks

Comment 9

[isabelrios]

The behavior now is the same in both scenarios. I have done more testing and everything looks fine.

Thanks and sorry for the delay!

Comment 10

[isabelrios]

Fire E 2.0
Loop 1.1.1/39a5284

Verified