1126334 - Hello Icon should change colour when screensharing is active

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Mark Banner (:standard8)]

As per the UX, we should be changing the colour of the Hello icon on the toolbar when screensharing is active within Hello.

Comment 1

[Mark Banner (:standard8)]

Attachment: Hello Icon should change colour when screensharing is active.

This sets the icon depending on the screen share state. I've accounted for multiple rooms at the moment, which is mainly because its possible, even though it is unlikely - however it doesn't add much code complexity so seemed reasonable to do.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8559795 [details] [diff] [review]
Hello Icon should change colour when screensharing is active.

Review of attachment 8559795 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-loop.js
@@ +193,5 @@
>        let state = "";
>        if (MozLoopService.errors.size) {
>          state = "error";
> +      } else if (MozLoopService.screenShareActive) {
> +        state = "action";

How are users supposed to know that this means screensharing is active? Does the tooltip update?

Comment 3

[Mark Banner (:standard8)]

I'll file a follow-up bug for the tooltips.

https://hg.mozilla.org/integration/fx-team/rev/c077e79e1771

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c077e79e1771