Hello Icon should change colour when screensharing is active

RESOLVED FIXED in Firefox 38

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla38
Points:
3
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox38 fixed)

Details

(URL)

Attachments

(1 attachment)

As per the UX, we should be changing the colour of the Hello icon on the toolbar when screensharing is active within Hello.
Assignee: nobody → standard8
Iteration: --- → 38.2 - 9 Feb
Created attachment 8559795 [details] [diff] [review]
Hello Icon should change colour when screensharing is active.

This sets the icon depending on the screen share state. I've accounted for multiple rooms at the moment, which is mainly because its possible, even though it is unlikely - however it doesn't add much code complexity so seemed reasonable to do.
Attachment #8559795 - Flags: review?(jaws)
Depends on: 1130356
No longer depends on: 1130356
Comment on attachment 8559795 [details] [diff] [review]
Hello Icon should change colour when screensharing is active.

Review of attachment 8559795 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-loop.js
@@ +193,5 @@
>        let state = "";
>        if (MozLoopService.errors.size) {
>          state = "error";
> +      } else if (MozLoopService.screenShareActive) {
> +        state = "action";

How are users supposed to know that this means screensharing is active? Does the tooltip update?
Attachment #8559795 - Flags: review?(jaws) → review+
I'll file a follow-up bug for the tooltips.

https://hg.mozilla.org/integration/fx-team/rev/c077e79e1771
Target Milestone: --- → mozilla38
https://hg.mozilla.org/mozilla-central/rev/c077e79e1771
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox38: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.