Closed Bug 1126334 Opened 7 years ago Closed 7 years ago

Hello Icon should change colour when screensharing is active

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal
Points:
3

Tracking

(firefox38 fixed)

RESOLVED FIXED
mozilla38
Iteration:
38.2 - 9 Feb
Tracking Status
firefox38 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

()

Details

Attachments

(1 file)

As per the UX, we should be changing the colour of the Hello icon on the toolbar when screensharing is active within Hello.
Assignee: nobody → standard8
Iteration: --- → 38.2 - 9 Feb
This sets the icon depending on the screen share state. I've accounted for multiple rooms at the moment, which is mainly because its possible, even though it is unlikely - however it doesn't add much code complexity so seemed reasonable to do.
Attachment #8559795 - Flags: review?(jaws)
Depends on: 1130356
No longer depends on: 1130356
Comment on attachment 8559795 [details] [diff] [review]
Hello Icon should change colour when screensharing is active.

Review of attachment 8559795 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-loop.js
@@ +193,5 @@
>        let state = "";
>        if (MozLoopService.errors.size) {
>          state = "error";
> +      } else if (MozLoopService.screenShareActive) {
> +        state = "action";

How are users supposed to know that this means screensharing is active? Does the tooltip update?
Attachment #8559795 - Flags: review?(jaws) → review+
I'll file a follow-up bug for the tooltips.

https://hg.mozilla.org/integration/fx-team/rev/c077e79e1771
Target Milestone: --- → mozilla38
https://hg.mozilla.org/mozilla-central/rev/c077e79e1771
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.