Closed Bug 1126347 Opened 10 years ago Closed 10 years ago

[Loop] Settings screen isn't closed when user is going to join to room

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: lolimartinezcr, Assigned: crdlc)

Details

(Whiteboard: [Room1.1.1_TestRun2][In 1.1.1][loop approved for 1.1.1])

Attachments

(2 files)

20150127_163719.jpg
1.08 MB, image/jpeg
Details
Github pull request
61 bytes, text/x-github-pull-request
borjasalguero
: review+
Details | Review
Attached image 20150127_163719.jpg — 
Prerequisites:
User A logged in Mobile Loop application with MobileID.
User B logged in Desktop Loop application.
User B has created and shared a room with an user (for example: owdqa@gmail.es).

STRs:
1. User A taps on "Settings" button in Loop application.
2. User A clicks "Home" button.
3. User A clicks in browser, opens Email server (for example: owdqa@gmail.es) and taps on URL shared. -> StandaloneUI is open.
4. User A click in "Join" button.

Actual result:
"Select camera" screen is show and Settings screen in background. Please see image attached.

Expected result:
"Select camera" screen is show and Settings screen *isn't* in background.
Fire E 2.0
Loop 1.1.1/d4d6d37
Whiteboard: [Room1.1.1_TestRun2]
Summary: [Loop] Settings screen isn't closed when user is going to join to room and selec → [Loop] Settings screen isn't closed when user is going to join to room
I think it's not an easy fix as settings screen is over the rest of panels, so changing the way they have been designed and implemented seems to be complex and risky in this state of the release. 

Anyway, setting ni to Borja so he can comment or add more details.
Flags: needinfo?(borja.bugzilla)
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Flags: needinfo?(borja.bugzilla)
Attached file Github pull request — 

        Attachment #8555875 -
        Flags: review?(borja.bugzilla)

        Attachment #8555875 -
        Flags: review?(borja.bugzilla) → review+

    
    

    
  
in master:

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/a21db8b8f1e66b9486c6f8166c0cbdd26a9de420
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
  
Whiteboard: [Room1.1.1_TestRun2] → [Room1.1.1_TestRun2][Not in 1.1.1]

    
    

    
  
Tested and it's working fine, the problem is that I am seeing at the same time the issue reported in bug 1127386. As that's a critical one, let's wait to be fixed to do the uplifting of this patch.

    
    

    
  
After landing 1127386 and the follow-up one 1127779, I've tested again and all is working fine, so giving the approval
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1] → [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1]

    
    

    
  
1.1.1

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/c3fd71581bff3f73f53a8f25516775ca147017f7
Whiteboard: [Room1.1.1_TestRun2][Not in 1.1.1][loop approved for 1.1.1] → [Room1.1.1_TestRun2][In 1.1.1][loop approved for 1.1.1]

    
    

    
  
Tested and now settings isn't shown.
Verified on Fire E 2.0
Loop 1.1.1/ 39a5284
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: