1126374 - [RTL] "Call ended" overlaps the phone number on the Call screen when you have multiple calls

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Johan Lorenzo [:jlorenzo]]

Attachment: Screenshot

Prerequisites: 
Set the phone in Arabic.

STR
1. Make a call from the device under test
2. Receive a call to the device under test and pick it up
3. From the other device (from step 2), hang up

Actual results
"call ended" overlaps the phone number. See attached screenshot for details.

Comment 1

[Tamara Hills [:thills]]

Attachment: call-ended-rtl.png

Hi Stephany,

Can you take a look at this attachment and weigh in as to whether this looks ok from RTL perspective?  I adjusted things so there is room for the call ended string.

Basically, I'm asking about the part in red which happens when one of multiple calls hangs up.  The 'call ended' string was overlapping the contact previously.

Thanks,

-tamara

Comment 2

[Stephany Wilkes]

Thank you so much, Tamara. This looks good to me. Double checking with native speaker Ahmed as well.

Comment 3

[Tamara Hills [:thills]]

Hi Ahmed,

Any thoughts on this one?

Thanks,

-tamara

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] tamarahills:bugfix/1126374_Call_ended_overlap_rtl > mozilla-b2g:master

Comment 5

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:

https://moztrap.mozilla.org/manage/case/15513/

Comment 6

[Stephany Wilkes]

Flagging Kaze for review (comment #3) to spread the bug load a bit better.

Comment 7

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8563665 [details] [review]
[gaia] tamarahills:bugfix/1126374_Call_ended_overlap_rtl > mozilla-b2g:master

Please land when the RTL review is done, and you have fixed the one small problem that I called out in the PR.

Comment 8

[Tamara Hills [:thills]]

Hi Dylan,

Can you help move this one along?  We are still needing final RTL review from one of the native language speakers for some time now.

Thanks,

-tamara

Comment 9

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to Tamara Hills [:thills] from comment #3)
> Hi Ahmed,
> 
> Any thoughts on this one?
> 
> Thanks,
> 
> -tamara

My apologies for replying late to this
The screenshot from attachment 8557340 [details] looks OK to me :)
THanks!

Comment 10

[Tamara Hills [:thills]]

clearing NI not needed anymore.  Thanks Ahmed

Comment 11

[Tamara Hills [:thills]]

https://github.com/mozilla-b2g/gaia/commit/d4c3af78cd948f5965c2fa29a5fdfb5c00ae10ce

Try Run:  https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=ab9f62a41a61

NI to myself to ask for uplift.

Comment 12

[Tamara Hills [:thills]]

Comment on attachment 8563665 [details] [review]
[gaia] tamarahills:bugfix/1126374_Call_ended_overlap_rtl > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): RTL feature
[User impact] if declined: User would have a UI with one string overlapping another in RTL
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): Relatively low and should be easy to backout.
[String changes made]: no

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/c410c9620065fed509ef6a66b9be11e33b665379

Comment 14

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on Flame 3.0 master and on Flame 2.2.

No overlapping text following STR and caller name is truncated as demonstrated on comment 1.

Device: Flame 3.0 Master (full flash 319MB)
BuildID: 20150224010314
Gaia: 31ac1cd7a029d5e46dd7c92537b5c973c5d9826e
Gecko: 368c62292249
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0 Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Device: Flame 2.2 (full flash 319MB)
BuildID: 20150224002637
Gaia: 8e98fe665f3821d10d4d982cbb14cbe5b94d0be5
Gecko: 2b70d9d62799
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0