1126378 - [RTL] "ICE contacts" overlaps the arrow in the Emergency dialer

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Johan Lorenzo [:jlorenzo]]

Attachment: Screenshot

Prerequisites
Have a passcode set on the device
Have an ICE contact set.

STR
1. Go to the emergency dialer

Actual result
Due to the RTL placement of the string the arrow now overlaps the string. See  attached screenshot.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Can we put this under the feature-b2g 2.2 flag?

Comment 2

[Dylan Oliver [:doliver]]

triage: P1 for confusing UI on the emergency dialer

Comment 3

[Doug Sherk (:drs) (inactive)]

This is a chance to unify a bit more of the emergency and regular Dialers.

Comment 4

[GitHub Autolander Bot]

Attachment: [PullReq] autra:bug-1126378 to mozilla-b2g:master

Comment 5

[Augustin Trancart [:autra]]

Comment on attachment 8559254 [details] [review]
[PullReq] autra:bug-1126378 to mozilla-b2g:master

Hi Gabriel! 

Could you please review this patch? I hope you're the right person to r? :-)

Thanks!

Comment 6

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8559254 [details] [review]
[PullReq] autra:bug-1126378 to mozilla-b2g:master

This is looking good but I'd like to see one little change: you've used an element with the `placeholder' class to hold the arrow and I'd rather see it with a self explanatory id instead. I've left the relevant comments on the bug. Ask for review again once you've updated the PR.

Comment 7

[Augustin Trancart [:autra]]

Comment on attachment 8559254 [details] [review]
[PullReq] autra:bug-1126378 to mozilla-b2g:master

Thanks for the review! It is looking better this way :-)

Comment 8

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8559254 [details] [review]
[PullReq] autra:bug-1126378 to mozilla-b2g:master

Excellent, thanks.

Comment 9

[Dylan Oliver [:doliver]]

Thanks Augustin. Please land on master and request approval for 2.2.

Comment 10

[Fabien Cazenave [:kaze]]

Merged on master: https://github.com/mozilla-b2g/gaia/commit/1f36616

Comment 11

[Augustin Trancart [:autra]]

Comment on attachment 8559254 [details] [review]
[PullReq] autra:bug-1126378 to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bad layout for RTL
[User impact] if declined: In RTL language, user would see a broken UI
[Testing completed]: yes on flame 2.2
[Risk to taking this patch] (and alternatives if risky): moderate, only html and CSS change.
[String changes made]:none

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/f241a12feb882d2efb6e7fe4a8624346a634b30a

Comment 13

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/155525/

Comment 14

[Coler]

Attachment: Verify_RTL_ICE.png

This issue has been verified successfully on Flame 2.2.
Reproduce rate:0/5.
Attachment:Verify_RTL_ICE.png

Flame 2.2 build:

Build ID               20150214002504
Gaia Revision          ea64caf6d4ab03fc4472eca9f41f20d651d55fa9
Gaia Date              2015-02-13 05:27:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/6de30e6bbc84
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150214.044811
Firmware Date          Sat Feb 14 04:48:22 EST 2015
Bootloader             L1TC000118D0

Comment 15

[Coler]

This issue has been verified successfully on Flame 3.0.
Attachment:Verify_3.0.png

Flame 3.0 build:

Build ID               20150215010209
Gaia Revision          f0b93e0668ef9565bd6f050b15b4f794d59feb65
Gaia Date              2015-02-13 13:13:27
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e0cb32a0b1aa
Gecko Version          38.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150215.043133
Firmware Date          Sun Feb 15 04:31:43 EST 2015
Bootloader             L1TC000118D0

Comment 16

[Coler]

Attachment: Verify_3.0.png