Closed Bug 1126404 Opened 5 years ago Closed 5 years ago

[Settings][Data Connection] Data can be toggled on/off but the user does not actually receive a data connection

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:2.5+, b2g-v2.2 unaffected, b2g-master verified)

VERIFIED FIXED
blocking-b2g 2.5+
Tracking Status
b2g-v2.2 --- unaffected
b2g-master --- verified

People

(Reporter: dharris, Assigned: albert)

References

()

Details

(Keywords: regression, smoketest)

Attachments

(2 files)

Attached file Data Connection Logcat
Description:
The user can toggle the data connection UI on and off freely, however the user does actually receive a valid data connection. The user is unable send MMS, browse the internet etc., via data 

Prerequisite: Do not have a Wi-fi connection

Repro Steps:
1) Update a Flame to 20150127010228
2) Open Settings App> Cellular & Data
3) Toggled Data Connection to be enabled
4) Try to send an MMS, or Open browser and begin typing

Actual:
The user does not have a data connection

Expected:
User has a connection to data and is able to freely use apps that require it with ease

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150127010228
Gaia: b02ec9713e6de8d96c6954d2c0dfd0442b0656ac
Gecko: 38e4719e71af
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 10/10
See attached: Logcat, Video - http://youtu.be/mtBsdu3jnlw
Adding qaurgent for a regression window, as this fails multiple smoketests.

This issue does NOT occur on Flame 2.2

The user has a valid data connection and is able to browse freely

Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
BuildID: 20150127002504
Gaia: 80d5b797fd0497a7e3337b7798a21b2e1219681a
Gecko: 01bf1516a65b
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Contact: ychung
Initial Regression Window:

Last Working Environmental Variables:
Device: Flame 3.0
BuildID: 20150126052534
Gaia: 793773bb2944b42a85dd160049e605cbd880c4da
Gecko: 95c76c3b0172
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First Broken Environmental Variables:
Device: Flame 3.0
BuildID: 20150126132403
Gaia: b02ec9713e6de8d96c6954d2c0dfd0442b0656ac
Gecko: c3a90afa2dee
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce 
Gaia: 793773bb2944b42a85dd160049e605cbd880c4da
Gecko: c3a90afa2dee

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: b02ec9713e6de8d96c6954d2c0dfd0442b0656ac
Gecko: 95c76c3b0172

https://github.com/mozilla-b2g/gaia/compare/793773bb2944b42a85dd160049e605cbd880c4da...b02ec9713e6de8d96c6954d2c0dfd0442b0656ac

caused by bug 1112048
Ryan, can you take a look at this please? Looks like the landing for bug 1112048 may have caused this.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker) → needinfo?(ryanvm)
As I've told you before, you should be asking the patch author that question rather than the person who landed it on their behalf.
Flags: needinfo?(ryanvm) → needinfo?(alberto.crespellperez)
The patch just update the APN list in order to keep sync with the one used in AOSP (Android). PLease could you check what are your current APN settings?
Flags: needinfo?(alberto.crespellperez)
Blocks: 1112048
(In reply to Albert [:albert] from comment #5)
> The patch just update the APN list in order to keep sync with the one used
> in AOSP (Android). PLease could you check what are your current APN settings?

Data Settings, Message settings, A-GPS settings are on ATT Phone.
And I don't see anything other than "Add New APN" under Tethering settings and IMS settings.
(In reply to Albert [:albert] from comment #5)
> The patch just update the APN list in order to keep sync with the one used
> in AOSP (Android). PLease could you check what are your current APN settings?

:albert, can you please help with an immediate backout of this as we like to keep smoketests green for tomorrow's build ?

Once you have the fix and associated tests, feel free to land again. Thanks!
Flags: needinfo?(alberto.crespellperez)
I am not convinced a APN data update could cause a smoketest breakage, but I might be wrong here.

Here is Gecko pushlog between two builds.
http://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=95c76c3b0172&tochange=c3a90afa2dee
We need the updated APN list, we cannot backout the patch.

In order to avoid blocking the smoketest execution in green, I will suggest to enter APN manually to run the testing while the real issue is being investigated.

To check if this issue is due to a change in the APN data base, please compare 2.2 file with 3.0 (https://github.com/mozilla-b2g/gaia/blob/master/shared/resources/apn.json) then check if the change must be done in AOSP based first (https://android.googlesource.com/device/sample/+/master/etc/apns-full-conf.xml) and resync again here.
(In reply to Yeojin Chung [:YeojinC] from comment #6)
> (In reply to Albert [:albert] from comment #5)
> > The patch just update the APN list in order to keep sync with the one used
> > in AOSP (Android). PLease could you check what are your current APN settings?
> 
> Data Settings, Message settings, A-GPS settings are on ATT Phone.
> And I don't see anything other than "Add New APN" under Tethering settings
> and IMS settings.

It does not have sense because 'ATT Phone' apn has been updated and now it is called 'ATT Nextgenphone'.
Flags: needinfo?(alberto.crespellperez)
Last time we updated the APN list we saw that ATT only supports nextgenphone apn for AOSP master. 'nextgenphone' apn is used for LTE devices [1] so we had to implement a patch in order to override the LTE AT&T APN and use the old one called 'phone'.

That patch overwrites APNs according to carrier names, if an APN comming from AOSP has the same name as someone in apns_conf_local.xml marked as 'overwrite', the APN is replaced.

Currently, AT&T has changed the carrier name of the 'nextgenphone' APN so it is not being overwrited.

[1] http://developer.att.com/technical-library/apns/apn-descriptions-and-characteristics
Attached file Patch
Fix the APN overwrite process. Added 'carrier_name' to APN object in apns_conf_local.xml so we can find the APN that should be overwrite.

Also added a warning when an APN is not found, it will help to detect similar errors in the future.
Attachment #8555828 - Flags: review?(josea.olivera)
Assignee: nobody → alberto.crespellperez
While Jose Antonio reviews the patch could you check if it fixes the problem please?
Flags: needinfo?(ychung)
Duplicate of this bug: 1126262
Comment on attachment 8555828 [details] [review]
Patch

LGTM. I'll wait before r+'ing the patch until someone seeing the issue before checks whether if current patch fixes the issue. Data calls works fine on my side after taking this patch but sadly I don't have an ICC card I could reproduce the issue with.

Leaving the review request at me then.
Attachment #8555828 - Flags: feedback+
Yeojin, could you please see if this patch resolves the issue?
Keywords: qawanted
After applying the patch, the issue does NOT reproduce anymore. The data connection works properly.
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ychung) → needinfo?(ktucker)
Keywords: qawanted
Attachment #8555828 - Flags: review?(josea.olivera) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/03a38bd5255747a06c276029bceb61dcd6f5568b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
This issue is verified fixed on Flame Master.

Result: The data connection works properly when toggled on. 

Device: Flame Master (319mb, full flash)
Build ID: 20150130010210
Gaia: 8238eeacc7030b2cdbf7ab4eba2f36779b702599
Gecko: 29b05d283b00
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Put the 2.5+ flag in order to make this bug appearing on http://mozilla-b2g.github.io/b2g-dashboard/
blocking-b2g: --- → 2.5+
You need to log in before you can comment on or make changes to this bug.