1126408 - prfdcach.c:216:18: warning: unused variable 'pop' [-Wunused-variable]

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Daniel Holbert [:dholbert]]

New build warning, noticed when building mozilla-central after recent NSPR uplift:
{
pr/src/io/prfdcach.c:216:18: warning: unused variable 'pop' [-Wunused-variable]
}

The last usage of this variable was removed in bug 573192, at the very bottom of this commit: http://hg.mozilla.org/projects/nspr/rev/84acbf6789fb#l1.190

So, the variable itself can go away.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Here's the patch (with extra lines of context, to prove that the variable is indeed unused).

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8555373 [details] [diff] [review]
fix v1

Review of attachment 8555373 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the extra context lines!  Maybe we won't have to do this sort of thing when ReviewBoard hits.

Comment 3

[Daniel Holbert [:dholbert]]

[needinfo=ted to land this. Thanks in advance!]

Comment 4

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/projects/nspr/rev/63b456dbbb94

Comment 5

[(not currently active) Ted Mielczarek]

I landed this, but in hindsight is froydnj actually an NSPR peer? It's a trivial change so I'm not stressed about it.

Comment 6

[Daniel Holbert [:dholbert]]

I just tagged him to review it because he wrote the patch that made this variable unused (bug 573192) -- this is a (trivial) logical extension of that patch (and in a perfect world, it would have been part of his already-reviewed-by-an-nspr-peer bug 573192 patch). 

Thanks for landing, & sorry if that technically violated the review protocol -- I figured it was trivial enough that it wasn't worth worrying about. :)

Comment 7

[Nathan Froyd [:froydnj]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #5)
> I landed this, but in hindsight is froydnj actually an NSPR peer?

Just as long as people don't start taking this as precedent!