Closed
Bug 112642
Opened 24 years ago
Closed 24 years ago
XUL for new print dialog has windows line endings in CVS
Categories
(Core :: Printing: Output, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: bzbarsky, Assigned: roland.mainz)
Details
(Keywords: helpwanted)
Attachments
(2 files)
9.23 KB,
patch
|
roland.mainz
:
review+
brendan
:
superreview+
|
Details | Diff | Splinter Review |
223 bytes,
patch
|
Details | Diff | Splinter Review |
Whoever checked in this file used a broken CVS client (or checked in on Unix and
had a file with windows line endings).
Assignee | ||
Comment 1•24 years ago
|
||
The original file was written on OS/2, I simply put it in my tree and noone
screamed yet... sorry ... ;-(
Unformtunately I do not have CVS checkin permissions to fix this myself - need
help ... AFAIK dos2unix would be the right tool to fix this ...
Keywords: helpwanted
![]() |
Reporter | |
Comment 2•24 years ago
|
||
Assignee | ||
Comment 3•24 years ago
|
||
Comment on attachment 59711 [details] [diff] [review]
Patch. Get this reviewed, and I can land it.
r=Roland.Mainz@informatik.med.uni-giessen.de
Attachment #59711 -
Flags: review+
Assignee | ||
Comment 4•24 years ago
|
||
Comment on attachment 59711 [details] [diff] [review]
Patch. Get this reviewed, and I can land it.
Please ask cls/dauphin if this is really the "best" way to get rid of the DOS
crap ...
![]() |
Reporter | |
Comment 5•24 years ago
|
||
dauphin says this is he way to go. mailed reviewers.
Comment 6•24 years ago
|
||
Comment on attachment 59711 [details] [diff] [review]
Patch. Get this reviewed, and I can land it.
diff -wu would convince me totally, but looks good from here.
sr=brendan@mozilla.org
/be
Attachment #59711 -
Flags: superreview+
![]() |
Reporter | |
Comment 7•24 years ago
|
||
![]() |
Reporter | |
Comment 8•24 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Boris/Roland, please verify and mark verified-fixed...thanks.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•