1126566 - [email] Account settings layout regression

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Théo Chevalier]

Attachment: Issue

Layout on Email account settings has regressed since 2.1. Labels now have less room, and label for synchronization is even truncated. Not sure if it was able to go on two lines before, but as you can see on the screenshot the end of the string is now missing in French.

The same screen while creating a new account is also affected.

Comment 1

[Théo Chevalier]

Attachment: Issue

Comment 2

[Théo Chevalier]

We probably want a regression-window here, I'll let the devs decide if it's needed.

Comment 3

[James Burke [:jrburke]]

Attachment: GitHub pull request

This is a regression caused by the RTL changes in the changeset mentioned in bug 1064617 comment 11, so affects 2.2+ only.

The attached pull request fixes the issues. Thanks for catching this, sorry it slipped through on the first pass RTL changes. See the pull request to see screenshots that show how the French locale looks with the changes.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8555654 [details] [review]
GitHub pull request

Thanks for the elaborating comment in the CSS and the pretty pics (:tchevalier too!)

Comment 5

[James Burke [:jrburke]]

Merged in master:
https://github.com/mozilla-b2g/gaia/commit/3e5156c5cc1db13cb9d38521a148ea62a0fd6ecb

from pull request:
https://github.com/mozilla-b2g/gaia/pull/27729

Comment 6

[James Burke [:jrburke]]

Comment on attachment 8555654 [details] [review]
GitHub pull request

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Changeset in bug 1064617 comment 11 for initial RTL support. Since that change is already on 2.2, this change should be too.

[User impact] if declined:
Worse l10n experience, layout not as compact, some text cut off.

[Testing completed]:
Tested on flame device with French, and a RTL locale, along with English.

[Risk to taking this patch] (and alternatives if risky):
Very low, just some CSS tweaks and a class change for a few HTML elements.

[String changes made]:
none

Comment 7

[Théo Chevalier]

Verified fixed on latest master, thanks a bunch for fixing this so quickly!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/8f0f29135946ac65fc25e13ad245f8781fb2a44d