1126613 - RTL, SHB, Utility tray overlapping SHB

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gregor Wagner [:gwagner]]

Attachment: 2015-01-27-16-53-44.png

Comment 1

[Gregor Wagner [:gwagner]]

Where should the SHB be in a RTL scenario?

Comment 2

[Stephany Wilkes]

Gregor, is the question here about what's expected in landscape mode, and then what is expected in RTL landscape mode? It's hard to tell from the screenshot (which is not in Arabic)? Thanks!

Comment 3

[Gregor Wagner [:gwagner]]

(In reply to Stephany Wilkes from comment #2)
> Gregor, is the question here about what's expected in landscape mode, and
> then what is expected in RTL landscape mode? It's hard to tell from the
> screenshot (which is not in Arabic)? Thanks!

The SHB is always on the right side when you change to landscape mode. So the question is if the SHB should be on the left side when in RTL mode.

Comment 4

[Stephany Wilkes]

Attachment: 2015-01-07-02-52-54.png

I can't reproduce the issue as shown in the original screenshot. I turned the soft home button on and put the phone into Arabic on 2.2. Here is a screenshot of what I see.

Comment 5

[Gregor Wagner [:gwagner]]

(In reply to Stephany Wilkes from comment #4)
> Created attachment 8559975 [details]
> 2015-01-07-02-52-54.png
> 
> I can't reproduce the issue as shown in the original screenshot. I turned
> the soft home button on and put the phone into Arabic on 2.2. Here is a
> screenshot of what I see.

You are seeing the issue :) The overlay is overlapping the SHB. This shouldn't be the case.

Comment 6

[Stephany Wilkes]

Ha Gregor! :)

I'll add this to the bidi pattern, but I'd expect that the location and behavior of the SHB should not change in RTL. It should remain the same as in LTR languages, in both landscape and portrait modes.

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Stealing this one too.

Comment 8

[GitHub Autolander Bot]

Attachment: [PullReq] mikehenrty:bug-1126613-utility-tray-rtl to mozilla-b2g:master

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8560763 [details] [review]
[PullReq] mikehenrty:bug-1126613-utility-tray-rtl to mozilla-b2g:master

Easy one.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8560763 [details] [review]
[PullReq] mikehenrty:bug-1126613-utility-tray-rtl to mozilla-b2g:master

\O/

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/b8c8be44f6edb807a9ed0feb791488a1b6e4a7a1

Comment 12

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master.

Result: When the device is set in RTL mode, the utility tray does not overlap with SHB on an landscape-enabled app, such as Browser, Gallery, and Video.
 
Device: Flame Master (319mb, full flash)
Build ID: 20150210010523
Gaia: 0cf517083f7eb5fc269e1236edba50534f65e3cd
Gecko: 2cb22c058add
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
------------------------------
Leaving verifyme for 2.2 verification

Comment 13

[Sue]

Hi Michael,
This issue still exists on latest build of Flame 2.2 by STR in comment 0. Could you please help to confirm whether this issue will uplift to 2.2 build or not? Many thanks :)

Comment 14

[Michael Henretty [:mikehenrty][:mhenretty]]

I never requested uplift!

Comment 15

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8560763 [details] [review]
[PullReq] mikehenrty:bug-1126613-utility-tray-rtl to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Maybe not a regression.

[User impact] if declined:
RTL utility tray looks terrible with SHB.


[Testing completed]:
CSS change only, so manually tested.

[Risk to taking this patch] (and alternatives if risky):
Low risk, 1 line of css that affects RTL is the only change.

[String changes made]: none.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/0179935627012dfde3ca036c9a71035be463b7ad

Comment 17

[Shine(Leave from Mozilla)]

Attachment: Verify_Pass_Flame2.2.png

This Problem is verified as "pass" on latest build of Flame2.2 by the STR in comment 0.
Actual result: The utility tray does not overlap with SHB on an landscape-enabled app, such as Browser, Gallery, and Video.
See attachment: Verify_Pass_Flame2.2.png
Rate: 0/10

Device information:
Flame 2.2：(Pass)
Build ID               20150628002505
Gaia Revision          0179935627012dfde3ca036c9a71035be463b7ad
Gaia Date              2015-06-26 21:13:44
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/35e09270da3a
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150628.035537
Firmware Date          Sun Jun 28 03:55:48 EDT 2015
Bootloader             L1TC000118D0