Closed Bug 1126638 Opened 5 years ago Closed 5 years ago

Remove the "storage" permission from all manifests

Categories

(Firefox OS Graveyard :: Gaia, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: fabrice, Assigned: aron.bordin)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file)

It's useless since bug 1123637 landed.
Whiteboard: [good first bug]
Hi!
I'd like to be assigned to work with it.
Do I need to remove "storage":{}, from all manifests inside apps/ and tv_apps ?


Thx
Flags: needinfo?(fabrice)
(In reply to aron.bordin from comment #1)
> Hi!
> I'd like to be assigned to work with it.
> Do I need to remove "storage":{}, from all manifests inside apps/ and
> tv_apps ?

Yes, remove it from all the manifests in gaia that have it.
Assignee: nobody → aron.bordin
Flags: needinfo?(fabrice)
Hi Fabrice, 

It's my first bug... How can I add the review? flag to the Autolander attachment? Do I need to reattach the github link?

Thx
Flags: needinfo?(fabrice)
(In reply to Aron Barreira Bordin from comment #4)
> Hi Fabrice, 
> 
> It's my first bug... How can I add the review? flag to the Autolander
> attachment? Do I need to reattach the github link?
> 
> Thx

You can click on 'Details' then select the appropriate reviewer. I'll go ahead and add it to this bug.
Flags: needinfo?(fabrice)
Comment on attachment 8568313 [details] [review]
[gaia] aron-bordin:remove-storage-permission > mozilla-b2g:master

I feel that it's probably not too necessary to flag *every* peer for this change, so I think that either Fabrice or Tim could do an uber review of all of the changes.
Attachment #8568313 - Flags: review?(timdream)
Attachment #8568313 - Flags: review?(fabrice)
Attachment #8568313 - Flags: review?(timdream)
Attachment #8568313 - Flags: review?(fabrice)
Attachment #8568313 - Flags: review+
Thanks!
https://github.com/mozilla-b2g/gaia/commit/7512026a377271a0cade12d70846557f0bc7781c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
(In reply to Kevin Grandon :kgrandon from comment #6)
> Comment on attachment 8568313 [details] [review]
> [gaia] aron-bordin:remove-storage-permission > mozilla-b2g:master
> 
> I feel that it's probably not too necessary to flag *every* peer for this
> change, so I think that either Fabrice or Tim could do an uber review of all
> of the changes.

Thx!

I don't know if I have no permission, but when I click in the 'Details' there is no flag. http://s9.postimg.org/slo30xvov/Screenshot_from_2015_02_26_16_03_07.png
I can set a flag in my own attachments, but not in Autolander ones.
(In reply to Aron Barreira Bordin from comment #8)
> I don't know if I have no permission, but when I click in the 'Details'
> there is no flag.
> http://s9.postimg.org/slo30xvov/Screenshot_from_2015_02_26_16_03_07.png
> I can set a flag in my own attachments, but not in Autolander ones.

Ok, thank you for the details. This appears to be a bug in our process for sure, and I've filed bug 1137368 to address this.
You need to log in before you can comment on or make changes to this bug.