1126638 - Remove the "storage" permission from all manifests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[[:fabrice] Fabrice Desré]

It's useless since bug 1123637 landed.

Comment 1

[Aron Barreira Bordin]

Hi!
I'd like to be assigned to work with it.
Do I need to remove "storage":{}, from all manifests inside apps/ and tv_apps ?


Thx

Comment 2

[[:fabrice] Fabrice Desré]

(In reply to aron.bordin from comment #1)
> Hi!
> I'd like to be assigned to work with it.
> Do I need to remove "storage":{}, from all manifests inside apps/ and
> tv_apps ?

Yes, remove it from all the manifests in gaia that have it.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] aron-bordin:remove-storage-permission > mozilla-b2g:master

Comment 4

[Aron Barreira Bordin]

Hi Fabrice, 

It's my first bug... How can I add the review? flag to the Autolander attachment? Do I need to reattach the github link?

Thx

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Aron Barreira Bordin from comment #4)
> Hi Fabrice, 
> 
> It's my first bug... How can I add the review? flag to the Autolander
> attachment? Do I need to reattach the github link?
> 
> Thx

You can click on 'Details' then select the appropriate reviewer. I'll go ahead and add it to this bug.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8568313 [details] [review]
[gaia] aron-bordin:remove-storage-permission > mozilla-b2g:master

I feel that it's probably not too necessary to flag *every* peer for this change, so I think that either Fabrice or Tim could do an uber review of all of the changes.

Comment 7

[[:fabrice] Fabrice Desré]

Thanks!
https://github.com/mozilla-b2g/gaia/commit/7512026a377271a0cade12d70846557f0bc7781c

Comment 8

[Aron Barreira Bordin]

(In reply to Kevin Grandon :kgrandon from comment #6)
> Comment on attachment 8568313 [details] [review]
> [gaia] aron-bordin:remove-storage-permission > mozilla-b2g:master
> 
> I feel that it's probably not too necessary to flag *every* peer for this
> change, so I think that either Fabrice or Tim could do an uber review of all
> of the changes.

Thx!

I don't know if I have no permission, but when I click in the 'Details' there is no flag. http://s9.postimg.org/slo30xvov/Screenshot_from_2015_02_26_16_03_07.png
I can set a flag in my own attachments, but not in Autolander ones.

Comment 9

[Kevin Grandon :kgrandon]

(In reply to Aron Barreira Bordin from comment #8)
> I don't know if I have no permission, but when I click in the 'Details'
> there is no flag.
> http://s9.postimg.org/slo30xvov/Screenshot_from_2015_02_26_16_03_07.png
> I can set a flag in my own attachments, but not in Autolander ones.

Ok, thank you for the details. This appears to be a bug in our process for sure, and I've filed bug 1137368 to address this.