1126685 - [UITest] bluetooth does not listen to the right event in v2

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[[e-mail]]

According to 
https://github.com/mozilla-B2G/gaia/blob/master/dev_apps/uitest/js/HW/bluetooth.js#L57

The mozBluetooth enable/disable event are replaced to listen 'adapter attribute changed'.

Or do it via enable()/disable().then callback

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] gasolin:issue-1126685 to mozilla-b2g:master

Comment 2

[[e-mail]]

Comment on attachment 8556360 [details] [review]
[PullReq] gasolin:issue-1126685 to mozilla-b2g:master

The root cause is uidemos app does not listen to the right adapter.attributechange to get proper stat and address.


The btHelper.getAddress can not guarantee it could get address in APIv2 unless we turn it into promise based api.

Since it's not widely used in other gaia app, as discussed, we will not support getAddress in v2.

Comment 3

[[e-mail]]

Test passed on flame.
1. open uidemos>HW>BT, turn on/off, the stat/address shows correctly
2. open settings and uidemos, turn BT on in settings then swipe into uidemos, the stat/address shows correctly

Comment 4

[[e-mail], [e-mail]]

Comment on attachment 8556360 [details] [review]
[PullReq] gasolin:issue-1126685 to mozilla-b2g:master

r+ with me! Well done.

Comment 5

[flin]

thanks!

Comment 6

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 7

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 8

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 9

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 10

[flin]

hacking the autobot again ;)

Comment 11

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 12

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 13

[flin]

merged to master https://github.com/mozilla-b2g/gaia/commit/55f192211656ecbb5a0b908843d02d178c58b1d0

thanks!