1126693 - Android SDK path suggested by bootstrap.py is wrong.

Status: RESOLVED DUPLICATE of bug 1123824

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Jonathan Hao (inactive) [:jhao]]

I tried to build Fennec in Ubuntu 14.04 following https://wiki.mozilla.org/Mobile/Fennec/Android#Preparing_your_build_environment

First, I did
> curl -O https://hg.mozilla.org/mozilla-central/raw-file/default/python/mozboot/bin/bootstrap.py && python bootstrap.py

At the end of the execution, it said

> Paste the lines between the chevrons (>>> and <<<) into your mozconfig file:
> 
> <<<
> # Build Firefox for Android:
> ac_add_options --enable-application=mobile/android
> ac_add_options --target=arm-linux-androideabi
> 
> # With the following Android SDK and NDK:
> ac_add_options --with-android-sdk="/home/jonathan/.mozbuild/android-sdk-linux"
> ac_add_options --with-android-ndk="/home/jonathan/.mozbuild/android-ndk-r8e"
> >>>

I pasted them to mozconfig and tried to do |./mach build|, but I got this error.

> configure: error: The path in --with-android-sdk isn't valid (source.properties hasn't been found).

I compared with https://wiki.mozilla.org/Mobile/Fennec/Android#Preparing_a_Fennec_mozconfig
It seems that the right path should be:

> ac_add_options --with-android-sdk="/home/jonathan/.mozbuild/android-sdk-linux/platforms/android-21"

Then I can build successfully.

Someone should fix the suggestion at the end of bootstrap.py.

Comment 1

[Prabhjyot Sodhi [:psd]]

Attachment: 1126693.patch

could have also made changes to https://dxr.mozilla.org/mozilla-central/source/python/mozboot/mozboot/debian.py#104
But did not since I thought, maybe the sdk_path variable maybe used elsewhere

Comment 2

[Nick Alexander :nalexander [he/him]]

Thanks for the patch.  The idea is correct but the implementation will fail, since suggest_mozconfig is also used on Mac OS X (with different inputs).  I'll land my patch on the other ticket without review.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8556950 [details] [diff] [review]
1126693.patch

Review of attachment 8556950 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.  I instead landed an older, slightly different patch on one of the duplicate tickets.