1126713 - [RTL][System] The settings icon is right-aligned when oauth iframe displays net error.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P3)

Description

[Sue]

[1.Description]:
[RTL][Calendar]The settings icon is not shown at left of screen when you log in a Google account in Calendar with no data and wifi connected.
See attachment:settingsicon.png

[2.Testing Steps]: 
Prerequisite: The device has no data and Wi-Fi network connected.
1. Launch Calendar.
2. Tap the drawer button.
3. Tap the settings icon.
4. Select Add Account -> Google.

[3.Expected Result]: 
4. The settings icon should display at left side of screen.

[4.Actual Result]: 
4. The settings icon is shown at right side of screen.

[5.Reproduction build]: 
Flame 2.2 build:
Gaia-Rev        80d5b797fd0497a7e3337b7798a21b2e1219681a
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/01bf1516a65b
Build-ID        20150127002504
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150127.035842
FW-Date         Tue Jan 27 03:58:52 EST 2015
Bootloader      L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Sue]

Attachment: settingsicon.png

Comment 2

[Miller Medeiros [:millermedeiros]]

this is not calendars fault, the behavior should be the same for any iframe that displays the net_error message. I'll provide a patch in a few minutes.

Comment 3

[GitHub Autolander Bot]

Attachment: [PullReq] millermedeiros:1126713-rtl-settings-icon-login to mozilla-b2g:master

Comment 4

[Ben Francis [:benfrancis]]

Comment on attachment 8561879 [details] [review]
[PullReq] millermedeiros:1126713-rtl-settings-icon-login to mozilla-b2g:master

Thanks

Comment 5

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 6

[GitHub Autolander Bot]

https://github.com/mozilla-b2g/gaia/pull/28097

The pull request could not be applied to the integration branch. Please try again after current integration is complete. You may need to rebase your branch against the target branch.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/7f31cce32c310409bb90135f5784868e62efb73e

Comment 8

[Coler]

This issue has been verified on Flame 3.0.
Attachment:Verify_RTL_Calendar.png.

Flame 3.0 build:

Gaia-Rev        e280a660955bbdab265d50f8d9e009de34082332
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/650863f6987b
Build-ID        20150211160231
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150211.192431
FW-Date         Wed Feb 11 19:24:42 EST 2015
Bootloader      L1TC000118D0

Comment 9

[Coler]

Attachment: Verify_RTL_Calendar.png

Comment 10

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8561879 [details] [review]
[PullReq] millermedeiros:1126713-rtl-settings-icon-login to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: icon will display at the wrong side of the screen (not following the RTL UX specs)
[Testing completed]: manual
[Risk to taking this patch] (and alternatives if risky): very low risk
[String changes made]: none

Comment 11

[Miller Medeiros [:millermedeiros]]

this blocks calendar-rtl so it should be considered a blocker

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/34de0e3611dad13b41285002c0b41d419d6cabff

Comment 13

[Brogan Zumwalt [Inactive]]

Verified fixed on Flame 3.0 

Settings icon on iframe when net error appears is left aligned when language is RTL. Checked on add Google account in Calendar app with no data connection.

needinfo-ing self and adding verifyme tag to test on tomorrow's nightly Flame 2.2

Device: Flame 3.0
Build ID: 20150224010314
Gaia: 31ac1cd7a029d5e46dd7c92537b5c973c5d9826e
Gecko: 368c62292249
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 14

[Brogan Zumwalt [Inactive]]

Issue verified fixed on Flame 2.2 Nightly

Settings icon on iframe when net error appears is left aligned when language is RTL. Checked on add Google account in Calendar app with no data connection.

Device: Flame 2.2
Build ID: 20150225002505
Gaia: ca64f2fe145909f31af266b1730874051ba76c78
Gecko: 16804008c29f
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 15

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15878/